Giter VIP home page Giter VIP logo

Comments (2)

swankjesse avatar swankjesse commented on May 17, 2024

SpdyConnection.writeSynReset(int, int) and SpdyConnection.writeWindowUpdate(int, int) are not problems because the class itself has synchronized on the offending methods:

  public synchronized void rstStream(int streamId, int statusCode) throws IOException { ... }
  public synchronized void windowUpdate(int streamId, int deltaWindowSize) throws IOException { ... }

The close method is potentially worth synchronizing. But that would cause it to block waiting for the completion of any in-progress writes. The current behavior interrupts those writes which is what we want.

from okhttp.

swankjesse avatar swankjesse commented on May 17, 2024

These comments from SpdyConnection describe our concurrency policy. In future bug reports, please describe either a logic problem with these rules or a code violation of them!

  // Internal state of this connection is guarded by 'this'. No blocking
  // operations may be performed while holding this lock!
  //
  // Socket writes are guarded by spdyWriter.
  //
  // Socket reads are unguarded but are only made by the reader thread.
  //
  // Certain operations (like SYN_STREAM) need to synchronize on both the
  // spdyWriter (to do blocking I/O) and this (to create streams). Such
  // operations must synchronize on 'this' last. This ensures that we never
  // wait for a blocking operation while holding 'this'.

from okhttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.