Domain name lookup doesn't support cancel or timeout about okhttp HOT 17 CLOSED

Hi, I've been working on this. I've created a PR (#4674) to get some feedback. Thx

from okhttp.

I just ran into this on version 4.11.0, so it appears to still be an issue, but I was able to work around it by wrapping my call with withTimeout. I'm using coroutines using the technique here: https://github.com/gildor/kotlin-coroutines-okhttp/blob/master/src/main/kotlin/ru/gildor/coroutines/okhttp/CallAwait.kt

As a user, it's surprising to me that the DNS timeout isn't included in the overall callTimeout.

from okhttp.

Requested upstream: https://code.google.com/p/android/issues/detail?id=56243

from okhttp.

Any news on this? It would be great if we could set a timeout for the DNS lookup. Typical use case is when a user connects to a WiFi that does not have an internet connection. It takes 20-30 seconds until the request fails and there is no way how to reduce this time.

from okhttp.

We are also running into issues with this. Do you know if any progress has been made on a workaround?

from okhttp.

Nothing at the moment. It's a difficult bug to fix because DNS is completely opaque in Java.

from okhttp.

see:http://stackoverflow.com/questions/693997/how-to-set-httpresponse-timeout-for-android-in-java/31643186#31643186

from okhttp.

Maybe we do DNS on a background thread? That’d probably be worth the cost, although potentially surprising.

from okhttp.

One more thing: now that our Dns interface is public, end-users can do this if they like.

from okhttp.

n.b. This is relevant for dnsoverhttps and there are also other viable dns clients now e.g. Netty impl is straightforward and can support timeouts. It would be nice if this was part of an overall request timeout even for a synchronous call.execute

https://github.com/yschimke/oksocial/blob/master/src/main/kotlin/com/baulsupp/oksocial/network/NettyDns.kt

from okhttp.

I was pondering the right API for this. Is it DnsCall + DnsCallback interfaces? That seems like a lot of code.

Another option is to make the DNS method async with coroutines, but that means we need a Kotlin dependency.

Other ideas?

from okhttp.

Punt until there is a story for a (future?) kotlin based OkHttp, hopefully with native support for coroutines?

In that scenario the system Dns impl, could use a IO thread pool for Dns requests.

from okhttp.

@yschimke @swankjesse Now that there is a kotlin based OkHttp in 4.x.x, is it possible to make more headway on this issue or are there any other blockers?

from okhttp.

Dupe of #5042?

from okhttp.

Yep, these are mutually redundant.

from okhttp.

Yeah, it should be, we just don't have the right API for it. We rely on the system DNS being well behaved. You could also implement your own Dns impl, with some shorter timeout.

from okhttp.

It would probably be more correct to use the AsyncDns implementation

https://github.com/square/okhttp/blob/6b91ea468c6b2931f9092232d8ebcf61076023ff/okhttp/src/jvmMain/kotlin/okhttp3/AsyncDns.kt

And default to Android Dns which supports it https://github.com/square/okhttp/blob/6b91ea468c6b2931f9092232d8ebcf61076023ff/okhttp-android/src/main/kotlin/okhttp3/android/AndroidAsyncDns.kt

With some other approach for JVM. but not likely soon.

from okhttp.