Excessive Code Duplication about square-ruby-sdk HOT 5 CLOSED

Hey @mvastola thanks for the feedback. Just FYI our SDKs are generated automatically and therefore not idiomatic, which is why you're seeing this. I've shared this with the team, though.

from square-ruby-sdk.

@StephenJosey, ok, but even if a script is used, that script can be changed to make much less repetitive code. As it is now, it's much harder to alter and add features.

Even more importantly though, this implies it's impossible to make PRs against this repo that could be merged. The code used to generate this library also needs to be open sourced so that this becomes possible.

from square-ruby-sdk.

We definitely appreciate the feedback, and we're looking into how we can clean this up. However, just for clarification, we will not be open-sourcing the code generator.

from square-ruby-sdk.

@mvastola PRs are welcome, but it's best to open an issue ticket first to discuss since we'll need to update the generator to match merged PR. As the generated code becomes more idiomatic and less repetitive, PRs should be easier to make and merge. Thank you for the feedback!

from square-ruby-sdk.

We definitely appreciate the feedback, and we're looking into how we can clean this up. However, just for clarification, we will not be open-sourcing the code generator.

@StephenJosey, this feels a bit weird to me. This brings into question why this repo is even on GitHub if it's not truly open source. I mean I guess there can be bugs, but by posting things on GitHub, companies send the message they embrace open source.

This isn't really a fair deal though -- people (Square's customers) can use this repo to improve your product (because you're willing to take their changes and apply them to your generator), but they then don't benefit from being able to reuse the codebase they're ultimately contributing to. Even worse, this is being done somewhat covertly -- you do not make the fact that this code is machine-generated public knowledge, so people don't know the terms of engagement when they contribute.

It really prompts the question -- why even have this on GitHub if this SDK isn't a truly collaborative effort? Why not just publish direct to rubygems? This isn't really how open source is supposed to work..

from square-ruby-sdk.