Giter VIP home page Giter VIP logo

Comments (5)

squidfunk avatar squidfunk commented on June 1, 2024 1

Fixed in 485fa76! Thanks for the excellent issue and reproduction, that made isolating and fixing the issue really easy. The problem was that the pathname change was not properly detected, which is now ensured by the document$ subscription and the double switch map on location$. The comment explains how it works:

mkdocs-material/src/templates/assets/javascripts/integrations/instant/index.ts

Lines 366 to 378 in 485fa76

// Handle instant navigation events that are triggered by the user clicking
// on an anchor link with a hash fragment different from the current one, as
// well as from popstate events, which are emitted when the user navigates
// back and forth between pages. We use a two-layered subscription to scope
// the scroll restoration to the current page, as we don't need to restore
// the viewport offset when the user navigates to a different page, as this
// is already handled by the previous observable.
document$.pipe(
switchMap(() => location$),
distinctUntilKeyChanged("pathname"),
switchMap(() => location$),
distinctUntilKeyChanged("hash")
),

Perfect issue! Thanks for taking the time.

from mkdocs-material.

rachel-rigdon-sp avatar rachel-rigdon-sp commented on June 1, 2024 1

Thank you so much for the fix! 🙌🏻

from mkdocs-material.

squidfunk avatar squidfunk commented on June 1, 2024 1

Released as part of 9.5.23.

from mkdocs-material.

soronpo avatar soronpo commented on June 1, 2024 1

Thank you so much!

from mkdocs-material.

squidfunk avatar squidfunk commented on June 1, 2024

Thanks for reporting! I'll investigate.

from mkdocs-material.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.