Giter VIP home page Giter VIP logo

Comments (5)

YemreGurses avatar YemreGurses commented on August 28, 2024

Created a new repository and tried to run a file streaming mapping job with simple patient-mapping and a csv file. Somehow, it doesn't run my job and gives this error. Error logs is not projected in GUI:

2023-09-04_11:12:12.931 [stream execution thread for [id = f69fed7d-4ac5-4b05-a58e-2740142e4153, runId = db574629-6b9f-4592-b430-b8f66d7fe10a]] ERROR o.a.s.s.e.s.MicroBatchExecution - Query [id = f69fed7d-4ac5-4b05-a58e-2740142e4153, runId = db574629-6b9f-4592-b430-b8f66d7fe10a] terminated with error java.lang.IllegalArgumentException: Option 'basePath' must be a directory

Repo: repo.zip

from tofhir.

Okanmercan99 avatar Okanmercan99 commented on August 28, 2024

No errors were detected after thorough testing with various combinations. To pinpoint the issue, please provide specific details about the settings that produced the incorrect result. @dogukan10

from tofhir.

dogukan10 avatar dogukan10 commented on August 28, 2024

@Okanmercan99 thanks, I'll also have a look at this issue in my spare time and let you know if I encounter any problems. Assigning the issue to me.

from tofhir.

dogukan10 avatar dogukan10 commented on August 28, 2024

I've tested it on main branch on 13/09/2023 and here is the result table:

  • toFHIR-engine / Batch job
mappingErrorHandling sinkSettings.errorHandling result
continue continue OK
continue halt OK
halt continue No FhirMappingJobResult log, only 1 mapping failure error (mapping_error) log, no log for invalid row error
halt halt No FhirMappingJobResult log, only 1 mapping failure error (mapping_error) log, no log for invalid row error
  • toFHIR-engine / Streaming job
mappingErrorHandling sinkSettings.errorHandling result
continue continue OK
continue halt OK
halt continue No FhirMappingJobResult log, only 1 mapping failure error (mapping_error) log, no log for invalid row error. The same error message is printed a couple of times.
halt halt No FhirMappingJobResult log, only 1 mapping failure error (mapping_error) log, no log for invalid row error. The same error message is printed a couple of times.

@Okanmercan99 I've used the same test data which I've already shared with you. With that test data, I expect to have following FhirMappingJobResult log:

  • Number of Invalid Rows: 1
  • Number of Not Mapped: 1
  • Number of Failed writes: 1
  • Number of Written FHIR resources: 7

Of course, if we have mappingErrorHanding=halt, then no resource will be generated and the mapping job will halt. In this case, we could have another field like "Number of Not Processed" or something similar to indicate that there are some rows which are not processed because of the mapping error. WDYT @suatgonul @sinaci @YemreGurses ?

Please let me know if you can not still reproduce the cases described above, we can have a test session to discuss this.

from tofhir.

Okanmercan99 avatar Okanmercan99 commented on August 28, 2024

We decided to remove this feature.

from tofhir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.