Comments (2)
Did some digging in the rotation issue, looks like Shape.rotate and Shape.translate methods all returns a copy of the object where the rotation/translation is already applied. So, the getting the Location() of rotated parts results in (0, 0, 0) rotation value eventhough the part is correctly rotated as per visually checking the exported stl.
There are two ways to go about this:
leaving this at it be since we know the rotation is correct. We just get any meaningful rotation info in code.
We can use the Shape.locate(Location) method to set a translation/rotation modifier. This correctly rotates the part in place. Only issue is the each call to locate(Location) overrides the current location with the provided parameter, and constructor for Location only takes rotation for one axis in euler angle, or rotation for all three axis in quaternion. So, If we want correct rotation and access to rotation info in code, we have to create a quaternion based on our euler angles and pass it to Location constructor and call locate(Location), which shouldn't be too hard to do. I'm not sure if I should introduce an extra dependency and use Scipy.quaternion or use OCP.gp_quaternion module whose usage seems more tricky.
I'm currently exploring the second option, but I'm not sure if it is worth the effort.
from stepcvt.
All the API functions return "copies" of the original object. In-place rotation is neither required nor desired for STL export, so don't do 2.
I believe it should be possible to retrieve "world" rotation if you do 1. But other strategies are possible. For now, as long as the exported STL files are being rotated, we can tackle the test later when we get more familiar with the API.
from stepcvt.
Related Issues (20)
- subparser for choices module HOT 6
- Support command line options related to part class for CLI HOT 3
- step_export_all_fails.py
- Add more tests for to_dict() in project class & Fix the bug HOT 5
- TaskInfo CLI
- newProject, editProject CLI for A7 HOT 1
- Serialization and deserialization for classes in Choices framework HOT 1
- CLI exportall
- CADSource test includes MacOS
- Load and write to json file in scripts HOT 2
- Project CLI test fails HOT 1
- Level 2 Deserialization HOT 3
- Edit cli_test HOT 1
- Edit cli_test
- Edit cli_test
- "stepcvt" not found as a command HOT 3
- fix issue with cadsource assemblies HOT 4
- adding root for Project.from_dict() HOT 1
- Change the command line options related to part class to support multiple sources
- Licensing HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stepcvt.