allow periods (.) in project names about goldberg HOT 6 CLOSED

The problem is the substitution strategy. If we replace unusable characters with an underscore or something, then you can't later add another project which really has underscores there. So, for now I'm leaning towards leaving this alone. Let me think about it for a bit.

from goldberg.

Well, I understand, however, the patch is not about allowing any kind of project name, it's simple deactivating rails' behaviour to 'format'. If right now you'd add a project with a period in it, rails will simply display an error page, as it tries to match the 'suffix' to a format.

In my example, I have projects running builds on different emulators to test for portability, so a project has a name like:
my_project_on_OpenBSD-4.4 - which would fail.

from goldberg.

Ah, ok. I understand now.

That, of course, causes another problem. If you have project called 'foo' your browser url would become '/projects/foo', and we also have '/projects/foo.png' which returns an image with the current status of the build to use in documentation pages. If we ignore dots in those urls that might stop the dot in '.png' also from working.

Let me think about this a bit more (unless you have a different suggestion).

from goldberg.

Interesting, I didn't even know that...
Well, the :constraints => {:project_name => /[^\/]+/} could be changed to match everything except for .png suffixes, etc..

from goldberg.

Fixed. Look at the commit above if you're curious. Basically, I figured out what approach travis-ci took to solve the problem.

from goldberg.

Thanks, that's definitely cleaner than my version!

from goldberg.