Comments (6)
The problem is the substitution strategy. If we replace unusable characters with an underscore or something, then you can't later add another project which really has underscores there. So, for now I'm leaning towards leaving this alone. Let me think about it for a bit.
from goldberg.
Well, I understand, however, the patch is not about allowing any kind of project name, it's simple deactivating rails' behaviour to 'format'. If right now you'd add a project with a period in it, rails will simply display an error page, as it tries to match the 'suffix' to a format.
In my example, I have projects running builds on different emulators to test for portability, so a project has a name like:
my_project_on_OpenBSD-4.4 - which would fail.
from goldberg.
Ah, ok. I understand now.
That, of course, causes another problem. If you have project called 'foo' your browser url would become '/projects/foo', and we also have '/projects/foo.png' which returns an image with the current status of the build to use in documentation pages. If we ignore dots in those urls that might stop the dot in '.png' also from working.
Let me think about this a bit more (unless you have a different suggestion).
from goldberg.
Interesting, I didn't even know that...
Well, the :constraints => {:project_name => /[^\/]+/} could be changed to match everything except for .png suffixes, etc..
from goldberg.
Fixed. Look at the commit above if you're curious. Basically, I figured out what approach travis-ci took to solve the problem.
from goldberg.
Thanks, that's definitely cleaner than my version!
from goldberg.
Related Issues (20)
- Perform a git-reset before doing a git pull HOT 1
- Poller Error "cannot start a transaction within a transaction" HOT 7
- Fix home page refresh HOT 6
- RVM fails to work properly if the .rvmrc is checked in HOT 3
- Use .rvmrc ruby if it exists
- suggestion: culprit checking code shouldn't be in view HOT 6
- Portability issues / suggestions HOT 6
- time of _projects.html.haml and builds.html.haml not necessarily in sync HOT 4
- svn cleanups HOT 2
- suggestion: making running more complex build commands easier HOT 4
- not easy to run! HOT 7
- Measure & Report on build times HOT 1
- Show commit message on the build page HOT 1
- Doesn't send any mail notification upon build completion HOT 6
- Show status as success even build has been failed HOT 2
- Updated configuration page with jruby configuration HOT 4
- Run ajax functionality specs using goldberg HOT 2
- Capybara specs are failing some time on goldberg HOT 1
- Not able to run specs through goldberg
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goldberg.