Option to append to existing Labels about labeler HOT 7 CLOSED

Hi, thanks for suggesting this!

from labeler.

Hi @maninder-singh-liqid I have been double checking this and I think the behaviour you describe is the current one. There is a unit test for this here: https://github.com/srvaroa/labeler/blob/master/pkg/labeler_test.go#L88

Can you provide more info about the specific case you're seeing? Is the existing label the same as one set in the rules, or different?

from labeler.

I investigated. The existing label is the same which is used in the rules. I wouldn't say it is a bug. But a feature based on use case of different projects.

The labels which are not used in the rules are not removed as expected.

from labeler.

Thanks @maninder-singh-liqid, the problem I see with that feature is that we'd have to check who placed the label in the first place to distinguish labels set by the user vs. labels set by the rule in a previous execution. AFAIK the GitHub API does not expose that information so it becomes hard to implement it.

from labeler.

@maninder-singh-liqid a valid option could be to add a configuration switch that will ONLY add append labels, but not remove them. There is a nuance: it will never remove them, regardless of who added them (e.g. if the action matches a rule to add a tag, but later the rule does not match, the label will stay). Would this suit you case?

from labeler.

that is an option to ponder on. For my use case the current behaviour is fine. thanks for your follow up.
May be having that option would benefit someone.

from labeler.

@maninder-singh-liqid I pushed a PR in the fix.42 branch. If you can give it a go to confirm this does what you expect that'd be great.

Thanks

from labeler.