RPC bugs between main thread and ui thread about patchwork HOT 7 CLOSED

Managed to get an example of the random error (number 3, above).
I noticed the req number was -45 for this error once in the past. Maybe a coincidence, maybe a pattern?

no stream for incoming msg
{
  "req": -45,
  "stream": true,
  "end": false,
  "value": {
    "key": "%fndO1NgfVjFjQ1xXogeNp+W4EjpKEagS9sMMY3LvjLs=.sha256",
    "value": {
      "previous": "%X0tzGRuIbvDsutjlCpmQ3ptjYSg+wkOFgb0m6ns/wKM=.sha256",
      "author": "@lQeCkxZlrHKCwsgY211KVunqeOFXlrumQfA7rnnf5Lw=.ed25519",
      "sequence": 75,
      "timestamp": 1439480448180,
      "hash": "sha256",
      "content": {
        "type": "post",
        "text": "Thu Aug 13 10:40:47 CDT 2015",
        "root": "%oMtWQGgf/bX75+6BYpNNZYJkJDyF/fUACjVc1NCHegI=.sha256",
        "branch": "%oMtWQGgf/bX75+6BYpNNZYJkJDyF/fUACjVc1NCHegI=.sha256"
      },
      "signature": "HIMU6g8iaoufg7ZglMti2ioFz9R3TXuUtFDjL6b/BEiiv6Fp6wuhBci0IYC25HO3+ckWULgwvl22kmBMDdDeBw==.sig.ed25519"
    },
    "prefix": []
  }
}

from patchwork.

Okay I this code is weird. I don't know. you have two things that are tightly coupled to each other even though they are in different repos. Are ipc messages always received in the order you send them?

from patchwork.

really, there should be a pull-ipc module that wraps electron ipc in a pull-stream, and then we are working with ordinary muxrpc. To know this is correct we need test coverage, and this would be a lot easier to test in it's own module.
If muxrpc has an ordering problem that is a big bug. however muxrpc is well tested so i don't think that is it.

from patchwork.

Progress report...
Published pull-ipc. Going to work on its test suite to make sure it's 100%, but I used it in the app briefly, and still saw the bug in this issue.
Also published electron-tape to help with writing tests in electron apps.

from patchwork.

awesome!

from patchwork.

SMH I think I solved this... muxrpc was behind a major version on the patchwork repo.

from patchwork.

Still looking good. I thought I saw the bug again, but that ended up being a bug in live-updating of secret message threads.

from patchwork.