Comments (18)
On second thought, i think component conversion should be first, to have less work for conversion
from color.
Hey bro, can I pick this up. Also your code is using class based components I you don't mind can I change them to functional based component
from color.
Hey I can add the slider for updating the columns and row for the color grid.
I have one query the row and columns should remain same or they can be updated individually.
from color.
I think they should be controllable seperately, but if you find single control better, then you may implement that.
Think about how a user might want it to be so they have better control over the app.
Should I assign this to you?
from color.
Yeah sure
from color.
You may convert it to functional components, i created it some time ago, and i don't remember why I picked class based
from color.
I can continue it in class base also. As you wise @SscSPs
from color.
@webcoderspeed please create an issue for "functional components" and you can work on that, i suppose this can be done by @00sukhjeet00
from color.
Yeah sure not an issue. Thanks assigning
from color.
@SscSPs Should I start working with class based or wait for @webcoderspeed to create functional based component and then start working on slider
from color.
I have created a issue #11 for converting class to functional components
from color.
Awesome!
You two please discuss with each other based on when you want to work on your tasks to clarify the timelines,
One needs to be done after another, either can be before othe other one.
@00sukhjeet00 @webcoderspeed whichever one takes less time can be done earlier and the other person can start after that or tomorrow
from color.
@00sukhjeet00 let me first complete the conversion from class based to functional and then after that
from color.
Okay, @webcoderspeed Thanks for conformation.
from color.
#11 @00sukhjeet00 bro you can proceed after the merge
from color.
Yeah sure
from color.
@00sukhjeet00 #11 was merged some time ago, you can work on this as you get time
from color.
Okay @SscSPs
from color.
Related Issues (20)
- Make Grid cells clickable and on click, copy the Colour HEX code to clipboard HOT 2
- Add a Header on the app to give it a app like UX HOT 2
- Responsiveness HOT 1
- Add CONTRIBUTING.md file HOT 1
- Add complementary color section HOT 5
- Remove unnecessary CSS HOT 1
- Add favicon and Title. HOT 1
- Add Live Demo link to the README.md HOT 3
- Add a notification/toast/tooltip message to let user know when user clicks to let them know its copied HOT 5
- Add a button mentioning the source code availability HOT 2
- Add "#" to copied color code HOT 2
- READ THIS - Instructions & Hacktoberfest ! HOT 2
- App's meta description is still the one created from create-react-app, need to update it HOT 11
- Readme link live project HOT 3
- add some effects in your heading[Color Picker] HOT 3
- Make choose any color(text) a little better HOT 9
- add margin to the heading. HOT 4
- Add a gradient to the "Color Picker" heading HOT 8
- Resposiveness issue and modify footer section HOT 1
- Website not responsive on mobile devices. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from color.