Giter VIP home page Giter VIP logo

Comments (18)

SscSPs avatar SscSPs commented on July 16, 2024 2

On second thought, i think component conversion should be first, to have less work for conversion

from color.

webcoderspeed avatar webcoderspeed commented on July 16, 2024

Hey bro, can I pick this up. Also your code is using class based components I you don't mind can I change them to functional based component

from color.

00sukhjeet00 avatar 00sukhjeet00 commented on July 16, 2024

Hey I can add the slider for updating the columns and row for the color grid.
I have one query the row and columns should remain same or they can be updated individually.

from color.

SscSPs avatar SscSPs commented on July 16, 2024

I think they should be controllable seperately, but if you find single control better, then you may implement that.
Think about how a user might want it to be so they have better control over the app.

Should I assign this to you?

from color.

00sukhjeet00 avatar 00sukhjeet00 commented on July 16, 2024

Yeah sure

from color.

SscSPs avatar SscSPs commented on July 16, 2024

You may convert it to functional components, i created it some time ago, and i don't remember why I picked class based

from color.

00sukhjeet00 avatar 00sukhjeet00 commented on July 16, 2024

I can continue it in class base also. As you wise @SscSPs

from color.

SscSPs avatar SscSPs commented on July 16, 2024

@webcoderspeed please create an issue for "functional components" and you can work on that, i suppose this can be done by @00sukhjeet00

from color.

00sukhjeet00 avatar 00sukhjeet00 commented on July 16, 2024

Yeah sure not an issue. Thanks assigning

from color.

00sukhjeet00 avatar 00sukhjeet00 commented on July 16, 2024

@SscSPs Should I start working with class based or wait for @webcoderspeed to create functional based component and then start working on slider

from color.

webcoderspeed avatar webcoderspeed commented on July 16, 2024

I have created a issue #11 for converting class to functional components

from color.

SscSPs avatar SscSPs commented on July 16, 2024

Awesome!

You two please discuss with each other based on when you want to work on your tasks to clarify the timelines,
One needs to be done after another, either can be before othe other one.

@00sukhjeet00 @webcoderspeed whichever one takes less time can be done earlier and the other person can start after that or tomorrow

from color.

webcoderspeed avatar webcoderspeed commented on July 16, 2024

@00sukhjeet00 let me first complete the conversion from class based to functional and then after that

from color.

00sukhjeet00 avatar 00sukhjeet00 commented on July 16, 2024

Okay, @webcoderspeed Thanks for conformation.

from color.

webcoderspeed avatar webcoderspeed commented on July 16, 2024

#11 @00sukhjeet00 bro you can proceed after the merge

from color.

00sukhjeet00 avatar 00sukhjeet00 commented on July 16, 2024

Yeah sure

from color.

SscSPs avatar SscSPs commented on July 16, 2024

@00sukhjeet00 #11 was merged some time ago, you can work on this as you get time

from color.

00sukhjeet00 avatar 00sukhjeet00 commented on July 16, 2024

Okay @SscSPs

from color.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.