Giter VIP home page Giter VIP logo

Comments (5)

sstur avatar sstur commented on August 10, 2024 1

There's not a super easy fix. The naive solution that comes to mind is to do a search and replace, but remember that modifying the content string in any way must make corresponding changes to the character meta data (style and entity) so it gets tricky.

I guess we could split on soft breaks and then use trimLeadingSpace/trimTrailingSpace for each part but I expect there is a better way (perhaps during the collapse white space part).

I'll have to take a closer look.

from draft-js-import-element.

sstur avatar sstur commented on August 10, 2024

Oh, I totally know what's causing this. There's even a friggin todo in the source:

// TODO: There could still be one space on either side of the break.

I'll try to get a fix out soon.

from draft-js-import-element.

afhole avatar afhole commented on August 10, 2024

Awesome, thanks. I started having a look at a fix but wasn't sure of the best way to go about it.
If you can point me in the right direction I will try and fix and raise a PR, otherwise I will leave it to you.
Cheers

from draft-js-import-element.

sstur avatar sstur commented on August 10, 2024

I've created #6 which seems to do the job well, but there's a lot of code there just to search & replace \n followed by a space.

I'm curious if you have any thoughts before I land this.

from draft-js-import-element.

afhole avatar afhole commented on August 10, 2024

Honestly I don't feel knowledgable enough with draft.js right now to be able to comment meaningfully (and regrettably don't have the time to reach that stage yet). I'm happy to test this also if you like otherwise I would say go ahead an merge it.

from draft-js-import-element.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.