Comments (7)
ewhauser
commented on July 30, 2024
1
I found another repository (https://github.com/api-definitions/keyval) using these rules and tried their setup. I confirmed that the above behavior does not occur in 7c95feba87ae269d09690fcebb18c77d8b8bcf6a.
I bisected this and tracked it down to 12b7ab45a92958bf33f90a44a10b1a3096fd1c6d as the bad commit.
from rules_proto.
pcj
commented on July 30, 2024
1
@paiyar agree let's revert that for now. I'll prepare a similar PR that you have on your branch.
from rules_proto.
sacsar
commented on July 30, 2024
I can confirm that reverting 12b7ab45a92958bf33f90a44a10b1a3096fd1c6d partially fixes the issue. The generated go code ends up alongside the originating protobuf, in other words, go_package is not respected.
from rules_proto.
sacsar
commented on July 30, 2024
Okay, the go_package thing appears to be user error on my part. I haven't figured out my mistake, but I have the same problem using 7c95feba87ae269d09690fcebb18c77d8b8bcf6a, which is known good.
from rules_proto.
paiyar
commented on July 30, 2024
@pcj Could you please advise if #248 can be reverted?
from rules_proto.
pcj
commented on July 30, 2024
@paiyar thanks for the notification. Let me take a closer look.
from rules_proto.
pcj
commented on July 30, 2024
Reverted in #315
from rules_proto.
Related Issues (20)
- Self-edges generated by some plugins HOT 4
- proto_repository doesn't work as documented
- Feature Request: Support Dart HOT 1
- Support strip_import_prefix HOT 8
- Cycle Dependency in `proto_cc_library` when per-file `proto_library` is disabled
- proto_gazelle doesn't work on subdirectory HOT 1
- Feature Request: Add support for protoc-gen-openapiv2 HOT 1
- proto_compile rule generator sorts "plugins" lexicographically HOT 1
- Failing to use rules_js/js_binary as a workable tool for proto_plugin HOT 1
- Failed to compile `proto_go_library()` HOT 2
- `proto_gazelle()` failed to use `config.yaml` HOT 5
- Some deps will not be resolved if run for only a dir HOT 1
- grpc server reflection failed in golang HOT 1
- WorkspaceSnippet is ignored in deps gen HOT 2
- Migrate to new rules_js/aspect_rules_ts? HOT 3
- rules_proto & rules_go problems / general dependency problems HOT 1
- checksum changed for `rules_proto` and dependencies HOT 1
- question: could you pinpoint the protoc version of this repository compared to bazelbuild/rules_proto? HOT 1
- bzlmod support HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rules_proto.