Get the scrub-themes.js script working about jamstackthemes HOT 5 CLOSED

I'm currently working on this so I can then move #26 forward.

@JugglerX What do you want the cutoff date for determining the "stale" status? A hardcoded date of January 1st, 2018 is being used. It should likely be based on a calculation from the current date. Is something like current date minus one year acceptable (so a repo without a commit in the past year would be considered stale)? Or should the period be shorter than a year?

from jamstackthemes.

@rgroves thanks for the PR with the scrub script. I did some work today which generates the github_branch and last_commit data in the generate-github.js - So this is available in data/themes.json

I was able to run scrub-themes.js and add the github_branch to the markdown files, which is nice. I also used it to generate a submission date for each theme. If we are going to be modifying the markdown files programmatically we need to decouple from using git info as the themes "submission date"

I tested the scrub script to generate stale data and it does, great! But I think this data should live in the data/themes.json not in the markdown. Let me know if you want to do that otherwise I can make the changes.

Really appreciate your work on this, thanks! :)

from jamstackthemes.

Sorry, I originally misunderstood where the stale flag should reside. I can work on moving this into data/themes.json via the generate-github.js script.

from jamstackthemes.

Ok sure. I agree it should exist in generate-github.js. stale flag is something we can update every build.

Broadly speaking. We want to avoid modifying the markdown files as much as possible. The scrub script should be used to make major updates to the markdown files when otherwise unavoidable.

from jamstackthemes.

That makes sense. Will have a PR for this later today.

from jamstackthemes.