Giter VIP home page Giter VIP logo

Comments (7)

hugoxiong5 avatar hugoxiong5 commented on May 13, 2024 1

@JoseLion Thanks, I will definitely try out the new version!

from react-native-spotlight-tour.

JoseLion avatar JoseLion commented on May 13, 2024

Thanks for the report @hugoxiong5!

I've seen this before and as far as I can tell this is an issue on react-native-svg with animated SVG components (probably software-mansion/react-native-svg#1857). However, it seems the issue was solved on v13.5.0+. You currently have v13.4.0, can you give it a try updating react-native-svg on your project? Thanks 🙂

from react-native-spotlight-tour.

hugoxiong5 avatar hugoxiong5 commented on May 13, 2024

Thanks for the help! Upgrading to react-native-svg v.13.5.0 solved the issue on Android.

Unfortunately, it also broke the web version of the spotlight tour a little bit, causing the spotlight animation not to display correctly (error message: Error: <circle> attribute transform: Expected transform function, "undefined).

Are you planning to support React Native Web with this library? For me, it's a big use case, so I'm going to stick with Expo SDK 46 for now (react-native-svg 12.3.0), where the tour library does work on all three platforms. Hopefully I can figure out a better way to upgrade later.

from react-native-spotlight-tour.

JoseLion avatar JoseLion commented on May 13, 2024

@hugoxiong5 thanks for the feedback! We haven't thought about support on React Native Web yet, but I think it's worth looking into it. I'll add it to our example and run some tests 🙂

In the meantime, it seems like the error you're getting might be also related to react-native-svg animations, but just in case, we just released v2.1.0, can you give it a try when you got some time? Would love some feedback on this new version too!

from react-native-spotlight-tour.

hugoxiong5 avatar hugoxiong5 commented on May 13, 2024

@JoseLion Unfortunately, when I tried to update to v2.1.0, the app crashed on React Native Web. (Works nicely on mobile--I like the new upgrades and options.)

Seems to be something causing Webpack compilation to fail:

Screen Shot 2023-03-04 at 9 35 56 AM

Screen Shot 2023-03-04 at 9 24 05 AM

Same package.json as the first post in this thread.

from react-native-spotlight-tour.

JoseLion avatar JoseLion commented on May 13, 2024

@hugoxiong5, it seems we might need to add some extra configuration to the package.json to support React Native Web. I'll open a separate ticket so we can tackle everything related to React Native Web support and give the appropriate focus to it. Thanks a lot for all your feedback! It helps us improve the library further 🙂

from react-native-spotlight-tour.

JoseLion avatar JoseLion commented on May 13, 2024

I'm closing this issue in favor of #95, which is specific to React Native Web support.

from react-native-spotlight-tour.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.