Python 3 Error - expected str instance, bytes found - mysql.insert about stackstorm-mysql HOT 4 OPEN

Looks like that is the trick. Had to do it in another place as well, but I now can test further and will open a PR with the fixes.

Thank you so much for your help @amanda11

insert.py

Before

query = "INSERT INTO {} ({}) VALUES ({})".format(table.encode('utf-8'), columns, values)

After

query = "INSERT INTO {} ({}) VALUES ({})".format(six.ensure_str(table.encode('utf-8')), columns, values)

base.py

Before

    def _escape_string(self, item):
        return MySQLdb.escape_string(unicode(item).encode('utf-8'))

After

    def _escape_string(self, item):
        return six.ensure_str(MySQLdb.escape_string(unicode(item).encode('utf-8')))

from stackstorm-mysql.

Does replacing:
self._escape_string(item)
with
self._escape_string(six.ensure_string(item))

solve it?

I had a similar problem with the str/bytes difference - under StackStorm-Exchange/stackstorm-openstack#30 (so you could also if I get any review comments on the way I've resolved it in that pack).

from stackstorm-mysql.

I tried it, and it provided the same error. Looks like it has an issue specifically with for item in data]). When trying something like str(item) i see the following error:

  File \"/opt/stackstorm/packs/mysql/actions/lib/base.py\", line 50
    for str(item) in data])
       ^
SyntaxError: can't assign to function call

from stackstorm-mysql.

I haven't got a mysql server but I took a simplified version of that action, and it looks like the self._escape_string is what is returning bytes.
So I think if you leave the list_to_string alone, but instead change escape_string to be something like:

return six.ensure_str(MySQLdb.escape_string(unicode(item).encode('utf-8'))) # pylint: disable=no-member

that might resolve the problem.

I'm definitely finding that the unicode(item).encode('utf-8') is converting the item to a set of bytes on python 3.

from stackstorm-mysql.