List: repetative recreating of child components may be a problem about cycle-onionify HOT 5 OPEN

I have some ideas for this, including one that would use diff and patch in order to know when to create a child component. I've done some experiments, but not enough to solve it.

So: work in progress.

from cycle-onionify.

André suggested, that memoization could help here, and it definitely will, but it doesn't look possible without introducing ids

That's ok. IDs can be used as a way to opt-in for optimization. I view this like virtual DOM keys: in many cases you don't need them, but putting them in will make the underlying library do less guessing work.

from cycle-onionify.

Ugly, ad-hoc caching, in the meantime:

  const cache = new Map<number, any>();

  const childrenSinks$ = array$.map(array =>
    array.map((item, i) => {
      if (!cache.has(i)) {
        cache.set(i, isolate(InnerComponentHere, i)(sources));
      }
      return cache.get(i);
    })
  );

(I noticed a minor downside to creating components as functions rather than classes - each class is also its own type, suitable to use as the value type in the Map.)

from cycle-onionify.

@kylecordes check issue #28

from cycle-onionify.

@staltz Thank you; I'm now using it.

from cycle-onionify.