ET Open ruleset contains commented rules about scirius HOT 5 CLOSED

I think it is a good idea to be able to enable all rules present in a rulefile. The end user however needs to be aware there could potentially be unwanted consequences - aka duplicates, perf hit, FPs etc.

from scirius.

I don't think enabling commented rules is a good idea. There will be too much noise. My idea is to:

• parse them
• add them to categories
• add them to disabled rules
  This way we get exactly what rules writer wanted to do.

from scirius.

Great idea! This would work great and be very true to what actually really happens... Those rules are disabled!

from scirius.

A few thoughts:

• maybe this is the case already but do you display disable rules by categories you can drill down? I think there are quite a few rules that are commented so you wouldn't just want to list individual rules as a flat list.
• I noticed some disabled rules have double # in front. So parsing only the rules with one # would not be enough

On the last point, this is why I didn't notice the rules were disabled with the original issue (windows download). There were so many lines starting with one # that I thought it was something like #include in C and that you had to have double # for disabling a rule (nothing to do with C)

from scirius.

Implemented in 1.1.2.

from scirius.