Comments (10)
This is now over 1 month old, any comments? @MansMeg @paul-buerkner
from posteriordb.
Im currently fixing everything for prototype draft. So I will answer asap.
from posteriordb.
I think this is probably a good idea. Although this is the current structure so I think we now add this as an improvement but not in the prototype.
from posteriordb.
This won't change the public API so we can do this later too, however I think it would be good to do this sooner than later. This is a quite small change so I could go ahead and prepare a PR for it soon.
However if you want more time to think if this is a good change we can also wait.
If we want to go ahead I think these are the required changes
- Add
.zip
todata_file
in every data info file - In https://github.com/MansMeg/posteriordb/blob/a6c90bbe1dd768a4c238253a09b8a453828cb05d/python/src/posteriordb/posterior_database.py#L68
remove the.zip
- Remove https://github.com/MansMeg/posteriordb/blob/62c4540e6f8ebedf9b4a457350c3fba1ab9a408e/rpackage/R/pdb.R#L245
and https://github.com/MansMeg/posteriordb/blob/62c4540e6f8ebedf9b4a457350c3fba1ab9a408e/rpackage/R/pdb.R#L253
I think there might be some other small changes required but nothing too big.
from posteriordb.
So I just added you to the repository. Start a new branch and change it there. Then I can fix the R stuff in that branch and when the branch works, we can merge it. You could see if you could get it to work with the R code.
It's just not the highest priority right now for me, but in the long run, we want it to be done.
from posteriordb.
Great! I think even if I start a new branch in my fork you'll still be able to make fixes directly to it. I will start with that as then there is 0% chance of accidently pushing to master in this repo. If we run into problems we can always merge that PR to a separate branch in this repo and continue from there.
from posteriordb.
I propose a further change. In addition to having filenames ending with .zip
like
"data_file": "content/datasets/data/8_schools.json.zip"
it is also possible to have
"data_file": "content/datasets/data/8_schools.json"
In this case the dataset file is not zipped in the posterior database but is just a normal JSON file.
I also suggest that most small files would be stored unzipped and only large files should be zipped.
from posteriordb.
Any comments on this?
from posteriordb.
I think it is easier to have all zipped for now?
from posteriordb.
I close this for now. If this becomes a problem down the line we solve that then.
from posteriordb.
Related Issues (20)
- `gh` package required HOT 2
- Nested sampling posteriors from ultranest HOT 3
- Example problems from astrophysics HOT 5
- Transferring to stan-dev HOT 1
- Updating Stan Models to be more performant HOT 3
- Convert golden samples to arviz IData HOT 3
- Add model code dependency structure
- Document data variables separately
- Handling of posterior licenses HOT 11
- Include explicit stan version in reference posterior computations
- install instructions for R package HOT 4
- Add eight schools with flat prior
- Add the occupancy model (population biology)
- Better examples needed HOT 5
- How to get the log probabilities of MCMC samples
- dogs-dogs not constrained properly in Stan HOT 1
- PyMC3 eight school example HOT 5
- Missing reference posteriors HOT 2
- Make a new release? HOT 3
- Change Stan syntax to new syntax HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from posteriordb.