Improving the python API about posteriordb HOT 8 CLOSED

Any comments @MansMeg @paul-buerkner?

from posteriordb.

Perhaps this could be an improvement to the dataset API

Accessing the loaded data JSON file

po.dataset.values()

values is a decently common python idiom for accessing the underlying values (for example xarray and pandas use it)

Get file path to the data JSON file

po.dataset.file()

from posteriordb.

I would appreciate some comments. Do you agree with this change or do you have some concerns? It's also fine to say "My gut reaction is negative but I can't yet articulate why" if that's the case.

from posteriordb.

I will go through this later.

from posteriordb.

So I think this new structure would be really good. It looks better. I think this would also simplify connecting to Github (and in the future a public database). I think it looks good.

from posteriordb.

Great! I'll do the changes soon (probably start of next week)

from posteriordb.

Me, Paul and Aki decided that the R package will be the reference implementation for now since this is where we are working now. so I remove this issue from the prototype milestone. If this can be fixed this coming week that would be great, because that when we expect the database prototype to come out.

from posteriordb.

That's fine. I'll very likely get these changes done this coming week.

from posteriordb.