Giter VIP home page Giter VIP logo

Comments (6)

lonsing avatar lonsing commented on August 12, 2024 1

yes, at least based on my tests, I think we can close it.

from pono.

ahmed-irfan avatar ahmed-irfan commented on August 12, 2024

Is it fixed now?

from pono.

lonsing avatar lonsing commented on August 12, 2024

@ahmed-irfan @makaimann

Your recent changes to the unroller made in https://github.com/upscale-project/cosa2/pull/42 and https://github.com/upscale-project/cosa2/pull/41 fixed the assertion failures related to the reference counting. Moreover, this also fixes all the assertion failures we had on the instances in the 'samples' directory.

I ported these changes to my debugging setup (https://github.com/lonsing/cosa2/tree/cosa2-refcount-debugging). I will do some more tests.

from pono.

ahmed-irfan avatar ahmed-irfan commented on August 12, 2024

Cool

from pono.

ahmed-irfan avatar ahmed-irfan commented on August 12, 2024

can we close this?

from pono.

makaimann avatar makaimann commented on August 12, 2024

Great! Closing it.

from pono.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.