Show Proofmode internal validation in "see more" about signal-x-proofmode HOT 9 OPEN

1. It shouldn't be on the fly - only when the "See more" screen is open
2. The verification doesn't unpack the entire app into memory - it operates on the streams in the file to verify the bytes. I think it is fairly memory efficient.

from signal-x-proofmode.

@maxSafronovForte – unzipping on the fly and fetching the PGP key for verification, is that doable? I remember we said in #34 that reading from the actual ZIPs could be really hard.

from signal-x-proofmode.

The ProofMode library provides a method for unpacking the zip and verifying everything. It just needs to be given an InputStream that points to the zip bytes, and then it returns a boolean whether the integrity check was successful or not.

I would recommend then, that any UI display would say something like "Signature and Hash Integrity Confirmed" possibly with "Signed by Key 0xABC123"

from signal-x-proofmode.

We can't do unzipping file on a fly(in message screen), cause it'll need a lot of resources of device
Example:

1. User sent us 50 messages
2. When user opens dialog with bot we can't start unpacking all zips, we can unpack only that files, which user can see

And if user do scroll - we start a lot of background threads which will unpack zips.
It cause time and device memory, when not every device can give us

from signal-x-proofmode.

We can put key in message body and in this case it'll easier to do

from signal-x-proofmode.

However, we can check whatever we want in "See more" screen
Example:

1. User press "See more" button
2. We pass zip file and other info in new screen
3. Show loading state while we unzip data and do some logic
4. Show whatever we want after loading state finished

from signal-x-proofmode.

So if we need to do verification in "See more" screen, we can plan this work just after Mobile Coin integration
What do you think, @basilesimon ?

from signal-x-proofmode.

Well, it seems like the "see more" button is offering us a neat way of doing this. I'm in agreement that, if feasible, this verification / check is worth surfacing – it would be a waste otherwise!

Nathan, Carrie and I actually discussed what "verified" means or might mean to a user. So your formulation below seems just right:

"Signature and Hash Integrity Confirmed" possibly with "Signed by Key 0xABC123"

Max, we can look at how to rank it in the priorities list on the board. I suspect we're starting to have a long list there, but at least that gives us options.

from signal-x-proofmode.

I've started looking into this. One challenge is that See More... is attached to the Photo+Message proof display, while the proof zip is in the subsequent separate message. Figuring out how to get a URI/inputstream handle to the proof zip now, which I expect @maxSafronovForte knows how to do.

from signal-x-proofmode.