Giter VIP home page Giter VIP logo

Comments (5)

kevincai avatar kevincai commented on July 29, 2024 1

@kevincai Doesn't it make sense to remove JAVA_OPTS_FOR_JDK_9 and JAVA_OPTS_FOR_JDK_11 from the default base values.yaml file? They are misleading.

ah, you are talking about the values.yaml for the helm chart installation. Yes, both can be removed from the default values.yaml

@yandongxiao

from starrocks.

kevincai avatar kevincai commented on July 29, 2024

the complication is introduced by the compatibility consideration if the user is upgraded from an old jdk version and then upgrade to the new one.

Ideally, if the user only provides JAVA_OPTS, it will be used as the final one, and if no JAVA_OPTS provided, the default one will be used.

from starrocks.

dengliu avatar dengliu commented on July 29, 2024

There are currently three places where JAVA_OPTS can be configured, which is confusing and increases the risk of mistakes.
According to our research, even when it is Java 11 environment, we need to config JAVA_OPTS_FOR_JDK_9 cc @mingmxu

Can we refactor the Helm chart to consolidate JAVA_OPTS into a single location in the values.yaml file?

image

https://github.com/StarRocks/starrocks-kubernetes-operator/blob/main/helm-charts/charts/kube-starrocks/values.yaml#L374-L376

from starrocks.

kevincai avatar kevincai commented on July 29, 2024

no. you can just clean all of the JAVA_OPTS_FOR_JDK9/JAVA_OPTS_FOR_JDK_11 all over the places and just keep the JAVA_OPTS in one place, that will take effect.

from starrocks.

dengliu avatar dengliu commented on July 29, 2024

@kevincai Doesn't it make sense to remove JAVA_OPTS_FOR_JDK_9 and JAVA_OPTS_FOR_JDK_11 from the default base values.yaml file?
They are misleading.

from starrocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.