Comments (5)
@kevincai Doesn't it make sense to remove
JAVA_OPTS_FOR_JDK_9
andJAVA_OPTS_FOR_JDK_11
from the default base values.yaml file? They are misleading.
ah, you are talking about the values.yaml
for the helm chart installation. Yes, both can be removed from the default values.yaml
from starrocks.
the complication is introduced by the compatibility consideration if the user is upgraded from an old jdk version and then upgrade to the new one.
Ideally, if the user only provides JAVA_OPTS, it will be used as the final one, and if no JAVA_OPTS provided, the default one will be used.
from starrocks.
There are currently three places where JAVA_OPTS can be configured, which is confusing and increases the risk of mistakes.
According to our research, even when it is Java 11 environment, we need to config JAVA_OPTS_FOR_JDK_9
cc @mingmxu
Can we refactor the Helm chart to consolidate JAVA_OPTS into a single location in the values.yaml file?
from starrocks.
no. you can just clean all of the JAVA_OPTS_FOR_JDK9/JAVA_OPTS_FOR_JDK_11 all over the places and just keep the JAVA_OPTS in one place, that will take effect.
from starrocks.
@kevincai Doesn't it make sense to remove JAVA_OPTS_FOR_JDK_9
and JAVA_OPTS_FOR_JDK_11
from the default base values.yaml file?
They are misleading.
from starrocks.
Related Issues (20)
- range partition key name prefix with '#' issue in 3.3.0rc2
- Repeated analyze in analyzeAggregations(SelectAnalyzer.java)
- named_struct function seems not functioning as its supposed to be while inserting data
- [FE] stop services in StarRocksFE.addShutdownHook
- [BE/CN] Too many warnning log In Kubernetes
- Add more refresh info into profile/audit log for performace analysis for materialized view refresh
- Long running alter job failed with task timeout error
- Data lost in kafka routine load internal error HOT 3
- Support populate datacache with a given probability.
- Hudi catalog improvement
- incorrect result of round HOT 2
- Hive catalog supports reading parameters in tblproperties
- Connection disconnection occurs when partitions are continuously built
- Docker images fail to restart after being stopped
- Environment variable or setting for root directory for all persistent data
- bugfix: create analyze job default behavior is inconsistent with documentation
- Unify Load Profile
- Weekly documentation feedback from readers
- Out of order INSERT INTO ORDER BY with primary key and unique key tables HOT 3
- add some causal inference algorithms
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starrocks.