Comments (9)
是的,因为我大多场景都是访问内网机器,这个的确没考虑到。后续考虑加密后再上传到gits,或者你提个PR?
from terminus-sync-config.
抱歉我看我密码被明文上传有点激动哈,我看你也几个月没更新了,我没写过typescript,你有没有搭建开发调试环境的文章教程啥的我参考下我到时候给你提个PR
from terminus-sync-config.
如果你会JavaScript那么你基本也会使用TypeScript。然后按照官方的指示既可开发。官方文档:https://github.com/Eugeny/terminus/blob/master/HACKING.md#plugins
值得一提的是在1.0.3版本中,密码的数据结构支持扩展,只需要加上部分字段即可。SettingsTab.component.ts
from terminus-sync-config.
自己琢磨了下环境搞起来了,PR提了,等你发版
from terminus-sync-config.
如果你会JavaScript那么你基本也会使用TypeScript。然后按照官方的指示既可开发。官方文档:https://github.com/Eugeny/terminus/blob/master/HACKING.md#plugins
值得一提的是在1.0.3版本中,密码的数据结构支持扩展,只需要加上部分字段即可。SettingsTab.component.ts
我动手的时候没看见这条,这密码的数据结构支持扩展啥的实在搞不懂,ts语法看着眼镜疼,先这样了
from terminus-sync-config.
{
host, port, user,
auth: {
// add this line
encryptType: 'NONE' | 'AES' | ... ,
password: pwd
}
}
auth
对象里可以添加一个标识,标识密码是否二次加密。
我看 #9 似乎并没有处理向上兼容。现在的密码是没有加密的,恢复的时候如果强行解密会导致很多错误。我觉得你可以根据 auth.encryptType( NONE | AES ...)
判断是否加密。
另外,我觉得不应该强制用户对配置加密,或许可以加个选项让用户选择是否加密。
from terminus-sync-config.
标识之后自动加密吗
from terminus-sync-config.
譬如:
我新增一个属性 auth.encryptType
,当我从gits拉下 ssh.auth.json
文件的时候并且在保存之前,我要先判断 auth.encryptType
是否等于(===) AES
,如果不等于表示没有加密则不需要解密,反之亦然。这样可以直接兼容之前没有加密的,后面如果用户不选择加密可以给这个auth.encryptType
设置成NONE
(默认值)。
另外,我觉得不应该强制用户对配置加密,或许可以加个选项让用户选择是否加密。
我的意思是并不是每个人都需要加密,大多数开发者连接的都是内网机器,我觉得不应该强制给用户做选择。
在这行代码上面,加个复选框(加密配置 or 加密密码),当复选框选中时这个输入框再显示,是否更好呢?
from terminus-sync-config.
Please use version 1.0.4
from terminus-sync-config.
Related Issues (18)
- 最新的1.0.6一启动就报错 HOT 1
- Plugins not start HOT 1
- Add Gitlab option to sync? HOT 1
- Auto Sync after change or add SSH connections HOT 2
- Hello, can you support custom gitlab tools?
- test issuse
- For gitlab deployed by your own server, can you add the function of customizing the gitlab server address HOT 4
- encrypt hots、name、ip,not just passwords. HOT 2
- 配置同步包括哪些内容,可以介绍一下吗 HOT 3
- Sync password doesn't work because config format upgraded
- 上传到GitHub Gist响应404 HOT 1
- Override username in sync config file HOT 1
- github with 404 HOT 3
- Feature Request: Github Enterprise
- win上传成功,但mac下载失败 HOT 1
- Plugin not loaded HOT 3
- A way to save two different configurations to two different gists? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminus-sync-config.