Comments (5)
Nice catch! Can you pull and try again?
from s4.
I happen to be getting a different issue now
TypeError: __init__() got an unexpected keyword argument 'hurwitz'
I can see that this is one of the parameters in the S4 block that was removed in one of the recent updates to the project, so I would assume that this might pop up in some other experiments as well if they weren't updated.
from s4.
You're right, I just pushed another fix for this.
Actually, I can't test right now on my local environment. The model API did change very slightly in the latest release and I wasn't able to test the Sashimi experiments, so there may be some small bugs in the configs. These should only be very small tweaks though in the model and configs. If you could figure out the necessary changes to get the model to run and report back, that would be extremely helpful :)
from s4.
I think your most recent commit fixed the issues with the experiments by just commenting out the hurwitz
parameter in the config files.
The stand-alone SaShiMi module still has an issue where in setup_rnn
, the mode is being passed to the submodules in the SaShiMi model on lines 443-444
for module in self.modules():
if hasattr(module, 'setup_step'): module.setup_step(mode)
but this is passed to the standalone S4 module which doesn't take in the mode as a parameter. I just changed the signature of each setup_step
function (in S4
and HippoSSKernel
) to pass in the mode downwards into the SSKernelNPLR
module for the time being. This is a pretty hacky fix though so I'm sure you might want to look into if there's a better way to handle this later. This leads to another error
torch._C._LinAlgError: linalg.solve: (Batch element 0): The diagonal element 1 is zero, the solve could not be completed because the input matrix is singular.
which I didn't run into beforehand when I tried python sashimi.py
prior to the modifications to the standalone S4 kernel implementation.
from s4.
V3 should have fixed any potential issues here. Feel free to re-open an issue if you find any further problems.
from s4.
Related Issues (20)
- Several examples doesn't work (Sashimi checkpoints / sampleRNN training) HOT 4
- information mismatch in s4/models/s4/experiments.md
- Paper, Table 1, Convolution number of parameters HOT 2
- About `krylov()` HOT 1
- Missing or misplaced "old" config folder? HOT 4
- "pretrained_model" is not defined before being called in train.py HOT 2
- Question on HMDB51 Dataset (S4ND Video Experiment)
- Unable to generate the weather using generate.py with time Series training checkpoint
- Large difference of inference result between forward and step
- AttributeError: 'SSMKernelDPLR' object has no attribute 'kernel' HOT 1
- Training on 12bits audio instead of 8bit? (Question, what do I need to change?)
- S4 Listops have nan loss HOT 2
- Quantization for S4/ Hippo
- The dynamics of the latent state of the model
- segmentation fault when running python -m train pipeline=mnist model=s4 HOT 1
- how to use the S4Block .step()
- KeyError in train.py self.dataset = SequenceDataset.registry[self.hparams.dataset._name_]
- Why is Sashimi's effect in speech signal enhancement (denoisy) so bad?
- Passing a video to S4ND
- CUDA error: no kernel image is available for execution on the device HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s4.