Comments (2)
I checked out the main branch and ran the tests. I saw some errors running typechain, but they went away when I blew away the artifacts folder. When I ran yarn
I got loads of changes to yarn.lock.
When I ran the tests, I saw the revert reason:
Error: cannot estimate gas; transaction may fail or may require manual gas limit (error="Error: VM Exception while processing transaction: reverted with reason string 'foobar'", tx={"da...
I saw the same with and without setting a manual gas limit.
I wonder if there could be some mismatch in ethers versions causing the different behaviour on our machines? Without an identical yarn.lock file, itβs hard to rule that out. #68
from safe-protocol.
@geoknee, thanks for looking into this! For future reference, if you use yarn 3.1.0 (or, likely, any somewhat recent version of yarn), you shouldn't see yarn.lock
changes.
from safe-protocol.
Related Issues (20)
- Enforce yarn version
- Add refunds to prototype
- Add liquidity provider address as contract initialization param on L1 and L2
- Factor out ticket hashing
- Contract fund distribution
- Set up auto-formatting
- Ecosystem background research
- Verify yarn instructions are correct
- Create more realistic testing scenario HOT 2
- Spike: Investigate incentivization
- Add support for L1<->L2 token mapping to L2 contract
- Setup linter/formatter for solidity
- Consider mapping of multiple L2 tokens to the same L1 token
- Edit the SAFE paper to discuss withdrawal and deposit chains as opposed to L2 and L1. HOT 1
- Review SAFE.md
- Spike: Try deploying to optimism testnet HOT 2
- Create Deploy scripts HOT 1
- Fix depositOnExitChain amountReserved to work with multiple token types
- Create separate long running benchmark
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safe-protocol.