Comments (6)
For those following along at home, it worked!
from xstate-tools.
Someone in Discord pointed out that inlining the guards makes the error go away. Unfortunately, doing that prevents you from using the visual editor.
from xstate-tools.
Huh, inlining a guard vs referencing a guard should definitely not result in such a behavior difference. This is definitely a bug - and most likely in XState itself
from xstate-tools.
Huh, inlining a guard vs referencing a guard should definitely not result in such a behavior difference. This is definitely a bug - and most likely in XState itself
To be clear, the machine executes properly at runtime regardless of where the guard is defined. It seems the VSCode extension just can't handle cyclic always
transitions and for some reason inlining the guard prevents the maximum callstack exceeded error (but inlining the guard might just be causing the extension to fail/abort parsing the machine before the error can happen?).
from xstate-tools.
Found a fix for this. XState was erroring too soon when you didn't provide a guard that was checked as part of an initial state. So we extract a bunch of 'guards to mock' from the machine definition.
By default, we were setting these guards as () => true
. But we don't need to. Setting them as () => false
works.
from xstate-tools.
(reopening pending @wKovacs64 feedback on a version distributed privately)
from xstate-tools.
Related Issues (20)
- [Feature Request] Add mermaid export to VSCode Extension HOT 1
- [Bug] VScode extension does not work if the machine is a property in a class HOT 5
- XState to md – how to generate documentation from xstate? HOT 1
- Bug: VSCode plugin error "<action> is never used in the machine definition" HOT 3
- xstate-cli typegen doesn't respect file casing after rename.
- Bug: typegen causes type error when a `service` is a function returning a StateMachine which has Context
- XState VSCode extension - Visual Editor shows unexpected errors when using multiple guarded transitions HOT 1
- @xstate/cli typegen regression from 0.5.2 HOT 2
- "Learn more" link button in vscode popup 404s HOT 1
- Running typegen command on machine with two invokes with one onDone fails
- (Feature Request) Use existing layout engine for autolayout HOT 1
- vs-code extension delete machine when defined as a createMachine parameter
- export to scxml file HOT 4
- VSCode Editor shows error on transitions when using "guard" (V5) instead "cond" (v4) HOT 2
- Bug: Typescript 'something is never used in the machine definition' when it is used HOT 2
- XState VSCode extension shows `__@@INLINE_IMPLEMENTATION@@__` string for all `onDone, onError` handlers in visualization
- Build instructions for vscode extension?
- Editor fails to save the changes on windows HOT 2
- "Jump to definition" doesn't work with v5's `setup(...)` API HOT 3
- Bug: VSCode visualizer doesn't resolve imported variables HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xstate-tools.