Comments (5)
@Parveshdhull Name if it's not there, it's not available.
We would not be pulling this info from waku since it would be too expensive for each users.
Ring should come from the media server and it's solely based on the public key, so that should be available regardless and I think we can fix this issue.
We should also be able to convert the keys, status-go has some endpoints to do that, albeit they might be synchronous and could be hanging the JS thread
from status-mobile.
hi @ilmotta, Thank you very much for creating this issue. #20431 is also caused by the same problem, missing contact data.
So I was wondering how can we fix this issue. We do have a buildContact
API in status-go which returns contact with some data like name as short public key with ellipses and ring etc.
We call this endpoint when we open the profile of any of the above users, and a contact is returned from status-go but it does not persist. So after restart only the public key is shown again. Is this bug and it supposed to persist? And what will be the drawback and performance effect of persisting so many contacts like for group/community members(because we are already storing some of them)?
Should we call build contact for every item/every time in this list? Or do we have some client-side function that will give us this data (ring, name), etc? btw, I am not sure how desktop fixes this. (maybe some client side function that returns name and ring)
@cammellos what do you suggest?
from status-mobile.
Thanks for picking this up @Parveshdhull. As mentioned in the issue's description, it would be good to find out from a desktop dev why the list of members in desktop doesn't have as many missing names as in mobile. Not a blocker for us to make progress here, but at least to know what they do differently and if we could do the same.
from status-mobile.
at least to know what they do differently
Hi @ilmotta, It seems desktop uses 3 random words name as fallback. (In 2.29.0)
from status-mobile.
It seems desktop uses 3 random words name as fallback. (In 2.29.0)
That makes sense @Parveshdhull 👍🏼
I verified again on the same desktop version I used before (2.29) and the member name I shared in the PR description no longer is shown as a compressed key. But there's a difference, the account I used a few days ago no longer worked and got locked out due to a crash after login, so I restored again the account, found the member again in the Status community, but this time it appears with the 3-word name fallback.
It seems that the fallback is the 3-word name, but there's still a chance that there's no information about the contact except their public key, so the very last fallback when the 3-word name doesn't exist is to simply use the compressed key. At least this is what we are seeing based on the screenshots below.
After starting from scratch and restoring, the same member appears as:
from status-mobile.
Related Issues (20)
- activity center notifications are shown during onbaording
- Existing Account Address is overwritten if the same account is scanned with chains
- Allow user to customize a group chat
- Add selected group chat members to as context-tags to the input
- Not all toasts are shown for Wallet Connect
- Update the group creation system message
- Update the system message sent when user is removed from a group chat HOT 1
- Input box does not expand on second line when drafting message
- Misaligned trailing letter in draft message
- App overlay overflows to task bar
- Enable wallet connect feature flag by default
- Events stuck in waiting for approval on dApp's side after signing in Status app HOT 4
- No result if user searches address by address with chains
- Limit the asset selection for bridge for ETH and stablecoins HOT 1
- Cursor is not visible in search field if user tries to edit entered address
- Hide Telemetry option in Advanced Settings
- App crashes after attempt to send collectible HOT 9
- The max value is not updated when network is disabled on the bridging page
- 🎴 Long dApp names are broken within request modal
- Activity is not shown HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from status-mobile.