Comments (7)
Released v1.10 including these changes. Thank you.
from blazorcontextmenu.
Thank you for your feedback. I can see the use case you are describing and I find it reasonable. I would however make this change be either:
a. Backwards compatible (add option to make it work on mousedown) OR
b. Make mousedown as the default but provide an option to make it work as it used to. -> (I prefer this)
If you are willing to make a fork and implement it according to the specification above then sure, I will be happy to accept your contribution.
If not, then the soonest I could work on this is during the weekend, no ETA though.
from blazorcontextmenu.
Nice project btw 👍
from blazorcontextmenu.
Thanks. 😊
I have time today and tomorrow so will give it a look.
I think approach B also sounds the best.
For this to be an option should that then be decided.
a. once for all uses in the project
b. local to a template (or default template)
c. local to every instance of the ContextMenuTrigger like:
<ContextMenuTrigger CloseOnMouseUp=true>ContextHere</ContextMenuTrigger>
Of cause, the naming is up for debate with that CloseOnMouseUp
which might be confusing.
from blazorcontextmenu.
Well, since the contexmenu itself has an boolean AutoHide
property, and since you can open the menu programmatically (and have it still close automatically), the new option should not be on the ContextMenuTrigger
.
Suggestion:
I think a simple enum property, something like AutoHideEvent
on the ContextMenu component will suffice for now
public enum AutoHideEvent
{
MouseDown, //default
MouseUp
}
Not sure if it should be included in the template though, seems a bit like overkill. It could be added later if needed.
from blazorcontextmenu.
Merged and working on the release
from blazorcontextmenu.
No problem. Happy to help! 🎊
from blazorcontextmenu.
Related Issues (20)
- Configurable direction of menu-open (e.g. bottom-right, top-left)
- SubMenu component doesn't use ContextMenuBase.ZIndex HOT 4
- "Cannot read properties of undefined (reading 'removeEventListener')" after closing menu HOT 3
- Support touch devices by changing to pointer events
- Scrolling menu options HOT 2
- Context menu does not close automatically if a dialogue menu is opened. HOT 1
- include blazorContextMenu.min.css and blazorContextMenu.min.js in a more Blazor like way. Reference the static files will not necessary HOT 1
- Context menu position on dialog windows HOT 2
- Disable menu item in table depending the model. HOT 2
- ContextMenuTrigger element is messing with table css rules HOT 1
- a way to detect which mouse button triggered context menu HOT 1
- "OnClick" actions not working in components HOT 2
- Uncaught (in promise) undefined HOT 1
- associate OnClick to a task made the component wait for the task is finish to close itself HOT 1
- Fix multiple security issue found in Microsoft.AspNetCore.Components 6.0.0 HOT 6
- About running speed HOT 4
- RTL Support
- Error on browser console when publishing on dotnet 8 HOT 2
- Scrolling Menu Items HOT 2
- TypeError when hovering over submenu items in BlazorContextMenu HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blazorcontextmenu.