Trigger closing of context menu depending on position of mousedown. about blazorcontextmenu HOT 7 CLOSED

Released v1.10 including these changes. Thank you.

from blazorcontextmenu.

Thank you for your feedback. I can see the use case you are describing and I find it reasonable. I would however make this change be either:
a. Backwards compatible (add option to make it work on mousedown) OR
b. Make mousedown as the default but provide an option to make it work as it used to. -> (I prefer this)

If you are willing to make a fork and implement it according to the specification above then sure, I will be happy to accept your contribution.
If not, then the soonest I could work on this is during the weekend, no ETA though.

from blazorcontextmenu.

Nice project btw 👍

from blazorcontextmenu.

Thanks. 😊
I have time today and tomorrow so will give it a look.
I think approach B also sounds the best.
For this to be an option should that then be decided.
a. once for all uses in the project
b. local to a template (or default template)
c. local to every instance of the ContextMenuTrigger like:

<ContextMenuTrigger CloseOnMouseUp=true>ContextHere</ContextMenuTrigger>

Of cause, the naming is up for debate with that CloseOnMouseUp which might be confusing.

from blazorcontextmenu.

Well, since the contexmenu itself has an boolean AutoHide property, and since you can open the menu programmatically (and have it still close automatically), the new option should not be on the ContextMenuTrigger.

Suggestion:
I think a simple enum property, something like AutoHideEvent on the ContextMenu component will suffice for now

public enum AutoHideEvent
{
     MouseDown,  //default
     MouseUp
}

Not sure if it should be included in the template though, seems a bit like overkill. It could be added later if needed.

from blazorcontextmenu.

Merged and working on the release

from blazorcontextmenu.

No problem. Happy to help! 🎊

from blazorcontextmenu.