Giter VIP home page Giter VIP logo

Comments (6)

TheNourhan avatar TheNourhan commented on June 14, 2024

If the input is : '{"type":"Complex64","re":5,"im":3}'
output is as follows : { re: 5, im: 3 }
is this correct?

from stdlib.

kgryte avatar kgryte commented on June 14, 2024

@TheNourhan No, that is not correct. Please re-read the OP. The OP is not requesting to materialize a JSON serialized string, but the result of z.toString().

from stdlib.

marsian83 avatar marsian83 commented on June 14, 2024

@kgryte Can you assign this issue to me.

from stdlib.

kgryte avatar kgryte commented on June 14, 2024

Thanks for volunteering to work on this issue @marsian83. Please feel free to submit a PR implementing this feature.

from stdlib.

marsian83 avatar marsian83 commented on June 14, 2024

Hi, @kgryte @Planeshifter
while approaching this I thought making an assert module @stdlib/assert/is-complexstring can make it easier to implement this and also parse-float-64 and would even help in any other scenarios where such an assertion might come in handy in a uniform and consistent manner.
Do you reckon this would be a good approach? or should I enclose the string validation logic within @stdlib/complex/parse-float32 itself

from stdlib.

kgryte avatar kgryte commented on June 14, 2024

@marsian83 Thanks for the thoughts. How about you create an RFC issue with the proposed package, API, and expected behavior? Once we review that and it is accepted, this could be a good candidate for a PR. That work?

from stdlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.