Giter VIP home page Giter VIP logo

Comments (6)

milroneth avatar milroneth commented on May 19, 2024 1

Based on Discord discussion on this, I like the idea of the URL bar. Would work by providing a GitHub repo URL which it will git clone.

Since devs asked for specific branches too, the easy way to implement without adding selector menus, having to read branches form the site, etc. would be to provide the branch URL directly, then the loader would just have to split the string and run a couple extra commands, scaffold code would look like:

Input: https://github.com/DevName/PluginName/tree/branchName

git clone $input
if $branchName {
  cd $PluginName
  git checkout $branchName
}

Sounds quick and easy, without much complexity.

from decky-loader.

Wolvan avatar Wolvan commented on May 19, 2024 1

Addition to @milroneth's comment, which I am very much in favor of by the way:
You can directly check out a specific branch during cloning by providing git with the -b <branch-name> parameter during clone, no additional checkout needed.
(Example: git clone -b dev https://github.com/Wolvan/spdck.git /home/deck/homebrew/plugins/spdck)

from decky-loader.

TrainDoctor avatar TrainDoctor commented on May 19, 2024 1

Not sure how this aligns with our idea of react plugins.

As soon as we ship react-based plugins, all plugins will have some kind of build step involved, converting JSX/TSX to JS and bundling all other possible dependencies. Since you normally don't want to store these "build" artifacts in the repo itself, branches are not runnable by default.

I have to agree unfortunately. I think we should move this to a URL that will support different repositories releases as already compiled code/binaries as the way to address this problem.

from decky-loader.

TrainDoctor avatar TrainDoctor commented on May 19, 2024

This is under consideration by the team. No more information at this time.

from decky-loader.

JohnnyCrazy avatar JohnnyCrazy commented on May 19, 2024

Not sure how this aligns with our idea of react plugins.

As soon as we ship react-based plugins, all plugins will have some kind of build step involved, converting JSX/TSX to JS and bundling all other possible dependencies. Since you normally don't want to store these "build" artifacts in the repo itself, branches are not runnable by default.

from decky-loader.

TrainDoctor avatar TrainDoctor commented on May 19, 2024

Zip files from URL are now supported in react-frontend-plugins branch.

from decky-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.