Giter VIP home page Giter VIP logo

Comments (6)

Stebalien avatar Stebalien commented on May 26, 2024

That definitely sounds useful.

Personally, I would call it something like labels! or items! because it can be used for more than class names. I'd also use a guard syntax (labels!("a", "b" if false, "c")) as it makes it clear that the booleans are conditionals. Finally, the recursive calls to format! will have very poor performance. Instead, consider implementing the Render traits for some helper struct (you can even make this generic over items implementing Render); this will allow you to write directly to the template buffer instead of allocating intermediate strings.

At the end of the day, it should be possible to write:

    div(class = labels!("active" if false, "button-style", format_args!("nth-{}", i /* a number */)) {
        : "this is a button"
    }

and get (assuming i = 10):

<div class="button-style nth-10">this is a button</div>

from horrorshow-rs.

Stebalien avatar Stebalien commented on May 26, 2024

If you need help with any of this, just ask. If you don't feel up for doing all of it, I can finish up anything you don't implement (i.e., partial PRs welcome).

from horrorshow-rs.

dashed avatar dashed commented on May 26, 2024

The additional suggestions sounds good.

I'm not totally clear on how to allocate TemplateBuffer.

from horrorshow-rs.

Stebalien avatar Stebalien commented on May 26, 2024

You don't. Just implement Render, RenderMut, and RenderOnce (modeled after Fn, FnMut, and FnOnce) and an &mut TemplateBuffer will get passed to you (it's an analog of Display's &mut Formatter).

from horrorshow-rs.

Stebalien avatar Stebalien commented on May 26, 2024

Actually, you can probably just generate a closure wrapped in an FnRenderer. That is, FnRenderer::new(|tmpl| { /* append appropriate labels to template */ }).

from horrorshow-rs.

dashed avatar dashed commented on May 26, 2024

Thanks. I created a PR attempt based on your suggestions.

from horrorshow-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.