Comments (6)
That definitely sounds useful.
Personally, I would call it something like labels!
or items!
because it can be used for more than class names. I'd also use a guard syntax (labels!("a", "b" if false, "c")
) as it makes it clear that the booleans are conditionals. Finally, the recursive calls to format!
will have very poor performance. Instead, consider implementing the Render
traits for some helper struct (you can even make this generic over items implementing Render
); this will allow you to write directly to the template buffer instead of allocating intermediate strings.
At the end of the day, it should be possible to write:
div(class = labels!("active" if false, "button-style", format_args!("nth-{}", i /* a number */)) {
: "this is a button"
}
and get (assuming i = 10):
<div class="button-style nth-10">this is a button</div>
from horrorshow-rs.
If you need help with any of this, just ask. If you don't feel up for doing all of it, I can finish up anything you don't implement (i.e., partial PRs welcome).
from horrorshow-rs.
The additional suggestions sounds good.
I'm not totally clear on how to allocate TemplateBuffer
.
from horrorshow-rs.
You don't. Just implement Render
, RenderMut
, and RenderOnce
(modeled after Fn
, FnMut
, and FnOnce
) and an &mut TemplateBuffer
will get passed to you (it's an analog of Display
's &mut Formatter
).
from horrorshow-rs.
Actually, you can probably just generate a closure wrapped in an FnRenderer
. That is, FnRenderer::new(|tmpl| { /* append appropriate labels to template */ })
.
from horrorshow-rs.
Thanks. I created a PR attempt based on your suggestions.
from horrorshow-rs.
Related Issues (20)
- Missing Fragment Specifier Warning HOT 2
- Context-aware escaping HOT 3
- Indenting / nesting content macro HOT 7
- Combining templates with `fold`/`match` -> no two closures have the same type. HOT 3
- error: no rules expected the token `tmpl` HOT 6
- Nice error messages
- improving example HOT 17
- no std support? + specify Cargo.toml in README HOT 2
- Infinite recursion with RenderOnce::size_hint HOT 1
- escaping converts foreign letters to < > HOT 1
- Add #[macro_export(local_inner_macros)] attribute to support Rust 2018 HOT 1
- Callbacks/passing values from the DOM back into Rust? HOT 2
- Empty div not closing properly HOT 4
- Indenting/reformatting in IntelliJ doesn't fix indentation HOT 2
- HTML boolean attribute support? HOT 1
- How to make a layout that accepts content? HOT 3
- Possibility for custom tags with hyphenated names? HOT 1
- Implement template into ActixWeb HOT 2
- wishlist: Explore applicability to DOM creation HOT 3
- Feature request: render to `Bytes` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from horrorshow-rs.