Giter VIP home page Giter VIP logo

Comments (2)

steelbrain avatar steelbrain commented on May 27, 2024

Pundle does not subscribe/check for status changes, It applies as soon as it gets it

According to the HMR API there's a addDisposeHandler that you can add and emit will-hmr in, and then do module.hot.accept('*', callback) in Pundle or module.hot.accept('.', callback) in Webpack and in that callback you can emit the did-hmr as it's invoked after the module is replaced

This is not ideal though, and will vary from bundler to bundler. (Pundle may not support ['*'] in the future).

I think the least side effective way to do it is to do something like

// Added process env check so static analysis can remove this node in prod
// instead of ignoring on runtime
if (process.env.NODE_ENV === 'development' && module.hot) {
  const { data } = module.hot
  if (data.oldView) {
    data.oldView.emit('did-hmr')
  }
  module.hot.addDisposeHandler(function(newData) {
    view.emit('will-hmr')
    newData.oldView = view
  })
}

from pundle.

RaeesBhatti avatar RaeesBhatti commented on May 27, 2024

This is fixed by #175

from pundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.