Comments (2)
Pundle does not subscribe/check for status changes, It applies as soon as it gets it
According to the HMR API there's a addDisposeHandler
that you can add and emit will-hmr
in, and then do module.hot.accept('*', callback)
in Pundle or module.hot.accept('.', callback)
in Webpack and in that callback you can emit the did-hmr
as it's invoked after the module is replaced
This is not ideal though, and will vary from bundler to bundler. (Pundle may not support ['*']
in the future).
I think the least side effective way to do it is to do something like
// Added process env check so static analysis can remove this node in prod
// instead of ignoring on runtime
if (process.env.NODE_ENV === 'development' && module.hot) {
const { data } = module.hot
if (data.oldView) {
data.oldView.emit('did-hmr')
}
module.hot.addDisposeHandler(function(newData) {
view.emit('will-hmr')
newData.oldView = view
})
}
from pundle.
This is fixed by #175
from pundle.
Related Issues (20)
- Npm 'github' fails on require HOT 1
- Be able to pass options to pundle from .motion.json HOT 1
- Run prettier across codebase HOT 1
- Imports not compiled HOT 1
- Weird one, ?react_perf loads both production and development react HOT 1
- Pundle breaks on pouchdb-adapter-memory HOT 5
- File gets imported twice when imported using * as and regular HOT 2
- Simple readme for running apps HOT 3
- Babel 7 HOT 2
- Support ES6 import/export without babel
- Worker loader! HOT 2
- Unexpected token / How to clear cache? HOT 2
- No update on changing linked modules outside project root HOT 5
- css-loader should ignore data URIs HOT 2
- Typeorm / Module alias or exclude HOT 2
- Store cache in a temporary directory to be cleared on reboot HOT 1
- Flatten entire bundle
- Import order error HOT 6
- Dedupe dependencies HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pundle.