resx_formatter_remove_documentation_comment should not ADD the documentation comment about resxformatter HOT 6 CLOSED

I was considering to do this in the beginning, but there were two things that lead to the current behavior:

• It was not quite clear how I should distinguish comments (I guess it can be done, but I did not have an immediate solution).
• The format does allow for comments as part of the schema e.g.:

<data name="abc" xml:space="preserve">
    <value>1</value>
    <comment>test comment</comment>
</data>

I am not going to be able to do anything here in the next couple of weeks, but I am going to consider to change the behavior unless of course you would be happy enough to use the "comment" notes that the RESX format provides.

from resxformatter.

I think I will not implement this for now because of the following reasons:

• Nobody seems to need this behavior
• My tests showed that the RESX Editor also removes such comments, which may have been the reason that I did not implement it in the beginning

from resxformatter.

I exclusively need XML comments for ReSharper https://youtrack.jetbrains.com/issue/RSRP-460830


There is no other reason.
I also use the <comment> feature.

If the cleanup would just leave the comments alone and not add them, I would already be happy 😄

Thank you for your time and effort!

from resxformatter.

Hey Stefan, I have chosen to rethink the R# problem and configured the inspection to not show anymore. This removes the need for XML Comments and I can use your great tool 😄.

You may close the issue if you want to keep the logic as is.

BTW: Support for .editorconfig - sooooo nice!

from resxformatter.

:-)

Thanks for the feedback... Resharper is a good reason to look into this some more. But as mentioned before it will take some time.

from resxformatter.

And as said, it's not really an issue for me anymore 😄

Thanks for your great work.

from resxformatter.