Giter VIP home page Giter VIP logo

Comments (6)

StefanTerdell avatar StefanTerdell commented on May 27, 2024 1

Done in master

from zod-to-json-schema.

StefanTerdell avatar StefanTerdell commented on May 27, 2024

Maps are not handled properly

it is not clear how to represent them

Pick one :)

It doesn't matter that it has a preprocess if it can't be guaranteed to be used all the time.

from zod-to-json-schema.

MOZGIII avatar MOZGIII commented on May 27, 2024

Pick one :)

Ok, fair.

It doesn't matter that it has a preprocess if it can't be guaranteed to be used all the time.

I'd be fine with an opt-in, since either way we build schema explicitly - maybe we could just have a configuration option?

from zod-to-json-schema.

MOZGIII avatar MOZGIII commented on May 27, 2024

I ended up using this hack:

const coercedMap = <K extends ZodTypeAny, V extends ZodTypeAny>(
  keySchema: K,
  valueSchema: V,
) =>
  z.preprocess(
  (arg, ctx) =>
      arg === undefined
        ? new Map()
        : new Map(
            Object.entries(arg as {}).map(([key, val]) => [
              keySchema.parse(key, {
                path: [...ctx.path, key, "<key>"],
              }),
              val,
            ]),
          ),
    // For JSON Schemas pretend we are an object rather than a map.
    tweaks.jsonSchemaHack
      ? (z.record(keySchema, valueSchema) as never)
      : z.map(keySchema, valueSchema),
  );

tweaks.jsonSchemaHack is a global that is toggled on when we export schemas, but is off for everything else.

What I'm looking for is to get rid of the tweaks.jsonSchemaHack - if it was possible to just tell zod-to-json-schema I am using z.map but I want it to look like a z.record that would be great.

from zod-to-json-schema.

StefanTerdell avatar StefanTerdell commented on May 27, 2024

Sure, wth.

from zod-to-json-schema.

MOZGIII avatar MOZGIII commented on May 27, 2024

Sweet! Thanks!

from zod-to-json-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.