Giter VIP home page Giter VIP logo

Comments (6)

steffest avatar steffest commented on August 23, 2024 1

Confirmed that nr1 is actually a bug - will be fixed soon.

from dpaint-js.

steffest avatar steffest commented on August 23, 2024 1

The "apply" bug has been fixed.
I added an "apply" button to re-apply the color reduction with current settings and if the palette option is set to "current", it now always takes the currently loaded palette.
image

Next to that, the "Alpha threshold" is now a checkbox.
If not enabled it leaves the alpha layer alone, keeping the transparency.
I'm not 100% sure that color reduction is 100% accurate for transparent pixels, especially when dithering is involved.
Colors get surprisingly complex surprisingly fast when transparency is involved ...
I'll keep this issue open for further testing.

from dpaint-js.

steffest avatar steffest commented on August 23, 2024

Hey! Thanks for testing dpaint.js :-)

1: Yes, I see your point. That's awkward.
I'll probably make a change that changes to the settings in the "reduce palette" don't auto-apply, but that there's a "apply button" you have to click, which will then also (re)take the current palette if the setting is set to "current"
(and maybe with an "auto-apply" option, becasue sometimes it's handy to quickly step through different settins and see the result instantly)

2: yes, that's a bit by design. Dpaint.js is targeted towards image formats for retro-systems like the Amiga and there is no real transparency there. You can paint transparent pixels if the brush is transparent, and have layers that are transparent, but a color itself doesn't have transparency. I don't think that will change any time soon.

3: Hmm.. I see. I my head, color reduction and alpha transparency don't go together (because you'll end up with more/different colors then you asked for) but I see you point. The "threshold" should be optional so that transparency can be retained. I'll put it on the TODO.

Thanks for the feedback !

from dpaint-js.

kevincrans avatar kevincrans commented on August 23, 2024

True, I agree with your decision on 2. Not trying to convince you, but I alrdy use no other values for transparency than 0%, 33%, 66% and 100%. GBA uses 1-bit alpha for a reason (however, if it's 0, then all other channels are wasted, but that could be efficient for the hardware colours & not having to redraw flickering sprites).

from dpaint-js.

steffest avatar steffest commented on August 23, 2024

Ah, forgot to mention; you can test this on the dev version on https://www.stef.be/dpaint/dev/
The dev version loads the current development codebase, which might be unstable, but most of the time it's fine :-)

from dpaint-js.

kevincrans avatar kevincrans commented on August 23, 2024

Thank you!

from dpaint-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.