services/horizon: Add "DISABLE_TX_SUB" configuration parameter about go HOT 5 CLOSED

Consider naming these as the inverse (ex. DISABLE_X). We currently have very limited test coverage around command line args, part of this effort should include adding that coverage

from go.

make sure data ingestion is happening by checking it's DB and If no ingestion is detected, Horizon should exit with an appropriate error.

This is interesting. Do you mean something like watching database state and seeing that e.g. select max(sequence) from history_ledgers; is increasing?

I think just having a Stellar Core to forward txsub and a valid db connection to should be enough, since the admin will see 504s if their db is not ingesting correctly. Wdyt?

from go.

make sure data ingestion is happening by checking it's DB and If no ingestion is detected, Horizon should exit with an appropriate error.

This is interesting. Do you mean something like watching database state and seeing that e.g. select max(sequence) from history_ledgers; is increasing?

Yes, that was my understanding as well.

I think just having a Stellar Core to forward txsub and a valid db connection to should be enough, since the admin will see 504s if their db is not ingesting correctly. Wdyt?

I agree, it seems like that should serve as a sanity check. What do you think @sreuland?

from go.

Suggestion to rename the flag TX_SUB_DISABLED to something like DISABLE_TRANSACTION_SUBMISSION or TRANSACTION_SUBMISSION_DISABLED

from go.

I think just having a Stellar Core to forward txsub and a valid db connection to should be enough, since the admin will see 504s if their db is not ingesting correctly. Wdyt?

I agree, it seems like that should serve as a sanity check. What do you think @sreuland?

yep, that proposed mechanism to detect ingestion may be all that's needed, it would mean invoking a request against STELLAR_CORE_URL to confirm valid response, etc, that mechanism was intentionally vague in the requirements as was expected to incur some investigation into what might be available for detection.

from go.