Comments (5)
@Reidmcc this is a good idea.
The change should probably be made in balancedLevelProvider.go
balancedLevelProvider can save (in memory) it's asset balances and the levels it returns from the GetLevels call. Anytime we call GetLevels it can first check if the asset balances have changed from what it has saved in memory:
- if it has changed then it can recompute new levels
- otherwise it can return the levels it has saved in memory.
This will be a pretty quick and simple code change.
The suggested approach will not consider amount tolerances since any balance change will trigger levels to be recomputed. Adjusting this to handle amount tolerances can be worked on as a separate issue which is a relatively small improvement over the suggested approach.
from kelp.
That makes sense. Do you have the code change planned out or shall I take a crack at it?
from kelp.
@Reidmcc The approach described above is what I had been thinking about for a while but never got to making the change. Would be great if you could take a crack at it!
from kelp.
Ok, will do.
from kelp.
@Reidmcc I've uploaded the fill tracking and handling logic, you can take a look at how that works for the mirror strategy as an example: https://github.com/interstellar/kelp/blob/master/plugins/mirrorStrategy.go#L312
from kelp.
Related Issues (20)
- Fill Tracker cannot unmarshal string into Go struct field Price._embedded.records.price.n of type int32 HOT 16
- newest GUI only support one tradetype "buysell"? how to convert to others tradetype?
- command-line run sample_pendulum.cfg prompt error
- GUI problem with checked the "Fill Tracter" on,the bot can not be start
- KELP is crashing after network upgrade HOT 1
- Critical BUG ⚠️ HOT 2
- kelp crashes after protocol update 18 HOT 2
- Not working after the P18 upgrade?
- Provide option to not build the GUI HOT 2
- no such file or directory libsodium.so.23
- linux-ia32-83_binding.node HTTP error 404 Not Found
- Private Stellar Network
- Add arm64 architecture to darwin platform
- Is there a guide on how to start the program? A video would be ideal!
- Coinmarketcap isn't working anymore for Kelp HOT 1
- OKX (OkeX): Integrate via API, Commissions up tp 60%?
- adjusting order size
- Infinite loop when encounters a trade that is different from base/quote asset HOT 5
- Add a bias to the weighting of buysell orders
- How to run on iPad⁉️
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kelp.