Giter VIP home page Giter VIP logo

Comments (9)

stephenberry avatar stephenberry commented on May 28, 2024 1

Bitsets do map to BEVE. From the spec:

Boolean arrays are stored using single bits for booleans and packed to the nearest byte.

from glaze.

justend29 avatar justend29 commented on May 28, 2024

Specifically, how would you want that serialized and how would you want that deserialized?

A string of 1's & 0's or an array of 1's & 0's would both make sense for humans. As for compactness, an array of the largest possible integers or a string of bytes, not characters, would be the smallest.

from glaze.

stephenberry avatar stephenberry commented on May 28, 2024

I feel like a string of 1s and 0s would be a good balance of human readable and more compact than an array.

from glaze.

justend29 avatar justend29 commented on May 28, 2024

Seems reasonable. If MSB is on the left, it would be enacting the same behaviour as to_string().

from glaze.

WillisMedwell avatar WillisMedwell commented on May 28, 2024

I think a string is a good approach, as you could also add a decorator (suffix/prefix) if you wanted to as well. The choice of a decorator, and which one to use, is up to you guys. For binary representations, I would think '0b' would be a good option.

from glaze.

stephenberry avatar stephenberry commented on May 28, 2024

Yeah, matching to_string() behavior like "10101100" would be great. We could allow "0b10101100", but I'm a bit cautious about this, because any time you allow multiple formats, it becomes more confusing to document and is slower if this is a runtime option. A user could easily add their own custom serializer/de-serializer to include 0b. But, I would just have Glaze read/write as "10101100" for now.

from glaze.

WillisMedwell avatar WillisMedwell commented on May 28, 2024

Yeah on second thought, thats a good call

from glaze.

justend29 avatar justend29 commented on May 28, 2024

@stephenberry Supporting bitset for binary formats seems like a no-brainer. Do bitsets map to BEVE?

from glaze.

stephenberry avatar stephenberry commented on May 28, 2024

Support has been added for JSON and BEVE read/write of std::bitset as of #526

from glaze.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.