[MSVC] `write_json` fails with `std::unordered_map<std::uint32_t, std::string>` about glaze HOT 5 CLOSED

Yeah, integer keys need quoted.hpp because the keys must be quoted. And quoted acts as a special wrapper, so it exists in its own header.

This will likely be improved/refactored in the future, but for now using numeric keys needs quoted.hpp to be included. I usually recommend using glaze/json.hpp for general JSON usage, but it does include more headers than you need. I'm going to close this issue as I don't intend to make a specific change to address this complexity, but expect that it will be improved in the long term. C++20 modules support when added should also remove the need for partial includes.

from glaze.

This should totally work. It looks like MSVC introduced an error with their latest release. I added your test case here #939, which passes, and there were already similar tests that have been passing (previous versions of MSVC).

I can upgrade my version of MSVC to this latest version and test myself. Will get back to you soon.

from glaze.

So, I was able to successfully build and run the code using MSVC v17.9.6 (the latest). What header files are you including to use Glaze? It might be a header include issue. Or, it might be some other setup problem on your side.

from glaze.

Interesting... These are my includes (in this order):

#include <glaze/binary/read.hpp>
#include <glaze/binary/write.hpp>
#include <glaze/core/common.hpp>
#include <glaze/json/read.hpp>
#include <glaze/json/write.hpp>

Edit.
I use these includes to silence clang-tidy (and it's also what it generates). Sorting is from clang-format.

from glaze.

And indeed, including <glaze/glaze.hpp> works, so yep, something iffy with the includes.

from glaze.