Giter VIP home page Giter VIP logo

Comments (4)

StephenCleary avatar StephenCleary commented on May 21, 2024

Monitor.WaitAsync is a method that changes the underlying state of the monitor. You especially need to be careful when using Task.WhenAny with synchronization primitives (there is almost never a good reason to do this).

In this case, as far as the monitor knows, it has two waiters: the first WaitAsync and the second WaitAsync. So when the Pulse comes through, it satisfies the first task, as it should.

FYI, the unit test for "pulsing a monitor releases a waiter" is here.

On a side note, unit tests that depend on timings are inherently unstable.

from asyncex.

niemyjski avatar niemyjski commented on May 21, 2024

Thanks for the heads up. I found that I needed to pass a cancellation token to the waiter and let it blow up (catch it)

from asyncex.

niemyjski avatar niemyjski commented on May 21, 2024

I see in your unit tests that you are entering the monitor to pulse. In your docs and my working unit test it doesn't mention that you have to do this. Is this required or just a best practice?

from asyncex.

StephenCleary avatar StephenCleary commented on May 21, 2024

Yes, it is required. I'll update the docs.

from asyncex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.