env=browser treated same as env=both. Causes globalThis.Buffer typescript error about ts-proto HOT 5 CLOSED

For me ts-proto generates code like this:

if (globalThis.Buffer) 

Which leads to typescript error:

error TS7017: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.

I want to support both node and browser with the same code. What would be the correct setting?

from ts-proto.

I want to support both node and browser with the same code. What would be the correct setting?

@jonaskello I guess for env=both, we could make the snippet be if ((globalThis as any).Buffer) and that will remove the TS warning.

If you'd like to submit a PR to do that, that'd be great!

I'm going to close this issue since #999 fixes the behavior with env=browser.

from ts-proto.

Got it. If I can find the time I'll make a PR for that.

I was able to work around it for now. We have all the generated files in a separate package with it's own tsconfig so I could disable the strict any setting for those files without affecting the rest of the app.

from ts-proto.

@jonaskello it was an easy fix, so I went ahead and pushed out a change to add the as any to the globalThis.Buffer check.

from ts-proto.

@stephenh Thanks for the quick fix. I tried 1.167.7 and it works for the base64FromBytes function but not for the bytesFromBase64 function. So I created PR #1005 with the same fix for that function.

from ts-proto.