Comments (7)
Wow, sorry man. I'll revert #39 right away.
from grunt-jslint.
After we pull #39, should we still try for a better algorithm? If we sort the files-to-lint and expand and sort the files-to-exclude arrays, then we can remove excluded files in one pass, so we wind up with
O( N lg N ) + O( M lg M ) + O( N + M )
where N is the number of files, M is the number of excludes.
from grunt-jslint.
@smikes Feel free to refactor, but for now, I've just reverted #39 and added a test for excluding files.
@jvrousseau I'll release a patch assuming the Travis build passes.
from grunt-jslint.
K. I'll take a look at it in a minute. Coincidentally working on globbing and inclusion/exclusion in node-jslint right now, and I am now very paranoid so I'm refactoring that and adding unit tests.
from grunt-jslint.
81c9f64 (1.1.7) has been pushed to npm
from grunt-jslint.
@jvrousseau There's a new version 1.1.8 - when you have the chance to upgrade and test it could you please let us know if it still works and does not cause a reversion of the broken 1.1.6 behavior.
Thanks!
from grunt-jslint.
it is working for me on both cases (wildcard and full name of file). Thank you for the help!
from grunt-jslint.
Related Issues (20)
- Travis build fails for current node 0.11 HOT 5
- Use node-jslint rather than a submodule HOT 9
- Passing es5 -- Not Catching Trailing Commas HOT 8
- Non-trivial exclude rules take forever to filter.
- Remove shelljs dep
- Honor excludes, but use faster algorithm HOT 5
- Error: EISDIR HOT 15
- Reading and removing BOM from UTF8 file HOT 3
- Options.edition with the aboslute path didn't work HOT 7
- Changes to node-jslint HOT 3
- node-jslint will require node 0.8 HOT 1
- How to set jslint options... HOT 1
- Warning: grunt-jslint's interface has changed HOT 2
- Ignore specific warnings HOT 4
- Request - option to run custom function if JSLint fails HOT 1
- Why is this error been thrown when I run jslint using grunt to improve my code quality? HOT 2
- Exclude is not working ... HOT 14
- will it be updated? HOT 9
- array.forEach is not a function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grunt-jslint.