Giter VIP home page Giter VIP logo

Comments (7)

stephenmathieson avatar stephenmathieson commented on August 18, 2024

Wow, sorry man. I'll revert #39 right away.

from grunt-jslint.

smikes avatar smikes commented on August 18, 2024

After we pull #39, should we still try for a better algorithm? If we sort the files-to-lint and expand and sort the files-to-exclude arrays, then we can remove excluded files in one pass, so we wind up with

O( N lg N ) + O( M lg M ) + O( N + M )

where N is the number of files, M is the number of excludes.

from grunt-jslint.

stephenmathieson avatar stephenmathieson commented on August 18, 2024

@smikes Feel free to refactor, but for now, I've just reverted #39 and added a test for excluding files.

@jvrousseau I'll release a patch assuming the Travis build passes.

from grunt-jslint.

smikes avatar smikes commented on August 18, 2024

K. I'll take a look at it in a minute. Coincidentally working on globbing and inclusion/exclusion in node-jslint right now, and I am now very paranoid so I'm refactoring that and adding unit tests.

from grunt-jslint.

stephenmathieson avatar stephenmathieson commented on August 18, 2024

81c9f64 (1.1.7) has been pushed to npm

from grunt-jslint.

smikes avatar smikes commented on August 18, 2024

@jvrousseau There's a new version 1.1.8 - when you have the chance to upgrade and test it could you please let us know if it still works and does not cause a reversion of the broken 1.1.6 behavior.

Thanks!

from grunt-jslint.

jvrousseau avatar jvrousseau commented on August 18, 2024

it is working for me on both cases (wildcard and full name of file). Thank you for the help!

from grunt-jslint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.