Output variable name difference for lib kafka_info is not optimal about ansible-kafka-admin HOT 2 CLOSED

Hi @Transrian,

PRs are always welcomed! :)

I agree with you that this is not ideal. As far as I know, I noticed the change in the key name while updating the Ansible version used in our tests and just thought this was due to this Ansible update, without really checking it. If you have a solution in mind, we would really like to see it and, since exit_json() just takes some kwargs as arguments, maybe we can keep the current results key for some versions while also providing the new one.

from ansible-kafka-admin.

Just found the culprit code for the ansible update: ansible/blob/devel/lib/ansible/plugins/action/init.py, introduced here

At first read, the reason:

results is used internally to handle loops, so your module should never return this key

I guess we should avoid this output name then (even if issue have been mitigated by their fix)

If you have a solution in mind, we would really like to see it and, since exit_json() just takes some kwargs as arguments, maybe we can keep the current results key for some versions while also providing the new one.

For now, while keeping the two version: results and a potentially new one, except by checking Ansible version (and compared it to when the patch was introduced, I don't see a good solution)

Some others library just changed their variable name to a new one, like here, to mitigate the issue

from ansible-kafka-admin.