Comments (4)
zawadz88
commented on June 3, 2024
1
Ok, this is now merged to master and will be in the next release. Thanks for the feedback!
from android-material-stepper.
zawadz88
commented on June 3, 2024
Hi @seasox,
Thanks for the feedback!
I agree with the proposed solution:
AbstractFragmentStepAdapter.findStep(ViewPager, int) requires ViewPager as first attribute and uses its getId(), which, as I see it it, always resolves to R.id.ms_stepPager. Would it be possible to remove ViewPager from findStep or provide an overloaded findStep(int)?
You are right - the ViewPager argument is redundant since this is always used with the ViewPager with R.id.ms_stepPager therefore it can be removed.
from android-material-stepper.
zawadz88
commented on June 3, 2024
Please see the changes in #65. Will that work for you?
from android-material-stepper.
seasox
commented on June 3, 2024
Hi @zawadz88, thank you! This should work.
from android-material-stepper.
Related Issues (20)
- new AndroidX library migration. HOT 1
- Skip step 2 verification and go to step 3 from step 1
- How to remove numbers from tabs? HOT 1
- Using a Singleton to keep data HOT 6
- Remove or Add Steps Conditionally HOT 1
- how to change icons and text in stepperLayout?
- How can i change the back button background with androidx HOT 1
- java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object java.lang.reflect.Constructor.newInstance(java.lang.Object[])' on a null object reference HOT 6
- Is there any well-supported fork out there? HOT 6
- it takes much time to create the activity hosting stepper fragments (about secs which is very long for the UI Thread)
- Having Issue applying style on StepperLayout HOT 1
- Please find a solution to this problem
- verify
- Error
- Can't change back and next button text programmatically HOT 1
- Padding next button and final button HOT 1
- move library to mavenCentral or other repo, Jcenter() is Deprecated HOT 3
- The fragments inside stepper shrink completely when keyboard is opened
- Step fragment is not working properly after recalling HOT 1
- Adapter Position issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-material-stepper.