Giter VIP home page Giter VIP logo

Comments (6)

Sterberino avatar Sterberino commented on May 23, 2024 1

I think that this issue is due to renaming the root node. It tries to get a reference to the existing tree using the name of the currently edited tree (which is a copy) via the root node and throws a null reference exception, I will try to fix it as soon as possible (probably tomorrow).

from open-behavior-trees.

MishterKirby avatar MishterKirby commented on May 23, 2024

Just did some further testing in an isolated environment and discovered that this is caused by having unattached nodes on the blackboard.

I personally feel those should be preserved even if they're not being used at the moment, but I'm not sure if what I'm currently experiencing is intended functionality or not.

from open-behavior-trees.

Sterberino avatar Sterberino commented on May 23, 2024

Just did some further testing in an isolated environment and discovered that this is caused by having unattached nodes on the blackboard.

I personally feel those should be preserved even if they're not being used at the moment, but I'm not sure if what I'm currently experiencing is intended functionality or not.

Sorry for the inconvenience, and that I haven't gotten to this yet. I'm in the middle of finals in my last quarter, actually.

When you say unattached nodes, are you referring to instances of BehaviorTreeNode? Because the tree is comprised of runtime copies of the existing ScriptableObject asset nodes. If you are trying to put nodes in the blackboard tree in the inspector, that would not work. You should instead insert the node using the OnInit() or OnStart() methods in BehaviorTreeNode.

from open-behavior-trees.

MishterKirby avatar MishterKirby commented on May 23, 2024

That's okay, please don't rush. Hope your finals go well.

As for unattached nodes, I mean nodes in the Node Editor. If you don't connect nodes together, as shown in this screenshot, you get the NullReferenceException error.
image

My expectation coming in was that I should be able to save the blackboard with such nodes still not hooked up.

from open-behavior-trees.

Sterberino avatar Sterberino commented on May 23, 2024

That's okay, please don't rush. Hope your finals go well.

As for unattached nodes, I mean nodes in the Node Editor. If you don't connect nodes together, as shown in this screenshot, you get the NullReferenceException error. image

My expectation coming in was that I should be able to save the blackboard with such nodes still not hooked up.

Oh yes, this is because the behavior tree you are working on in the node editor is a copy of the behavior tree asset (the root node). Those nodes can't have null parents, because they wouldn't be part of the tree. I can add a notification when trying to save a tree with unconnected nodes, but saving the tree without connecting the nodes wouldn't work as it currently stands. I would have to rework the implementation to something that uses explicit edges, I think.

from open-behavior-trees.

MishterKirby avatar MishterKirby commented on May 23, 2024

Oh, I see, that makes sense now. Thank you for the explanation.
I agree adding a notification would make the editor a bit more user friendly to use, and also would most likely be easier to implement, too.

On another note, should I leave this issue open for future reference, or can it be closed?

from open-behavior-trees.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.