Giter VIP home page Giter VIP logo

Comments (2)

stevearc avatar stevearc commented on June 3, 2024 1

This is a neat idea, and if it can be done with relatively minimal API changes that are pretty clean, I'm on board. The API that makes the most sense to me would be:

  • Add a second parameter to the callback function that is a boolean. This indicates if any changes were applied.
  • Add a dry_run option to format() that will skip applying changes, but keep the same logic for that formatted parameter.

This way we don't expose more information than is actually needed, we neatly sidestep the issue of "how do we combine normal formatter diffs with LSP format diffs", and it's something that could be useful for non-dry_runs as well. What do you think?

from conform.nvim.

bpjordan avatar bpjordan commented on June 3, 2024

This is a neat idea, and if it can be done with relatively minimal API changes that are pretty clean, I'm on board. The API that makes the most sense to me would be:

* Add a second parameter to the `callback` function that is a boolean. This indicates if any changes were applied.

* Add a `dry_run` option to format() that will skip applying changes, but keep the same logic for that `formatted` parameter.

This way we don't expose more information than is actually needed, we neatly sidestep the issue of "how do we combine normal formatter diffs with LSP format diffs", and it's something that could be useful for non-dry_runs as well. What do you think?

I like this as well. I wasn't sure if you'd want just the boolean return value, since it does limit the usefulness of this change, but I'm on board with leaving it that way since it does massively simplify the implementation.

from conform.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.