The presence of a message body in a request is signaled by a Content-Leng

I believe <a class="issue-link js-issue-link" data-error-text="Failed to load title" d

Content-Length or Transfer-Encoding header (RFC 7230) about simple-server HOT 3 OPEN

steveklabnik commented on July 22, 2024

Content-Length or Transfer-Encoding header (RFC 7230)

from simple-server.

Comments (3)

steveklabnik commented on July 22, 2024

I believe #90 has fixed this, by setting it automatically. @jbolila , any chance you could give master a try and see if wrk works?

from simple-server.

scurest commented on July 22, 2024

On master, examples/server.rs's response now looks like

< HTTP/1.1 200 OK
< content-length: 11
<

so it does include the content length and curl doesn't produce * no chunk, no close, no size. Assume close to signal end anymore.

But the Date and Connection fields are still missing. Date would be nice and easy to add. I'm not sure what would need to change to make keep-alive work though.

about wrk:

In my tests, since wg/wrk@522ec60 (~3 yrs ago) wrk will compute Req/Sec even without the Content-Length header.

The server will invariably crash after wrk finishes though. Cause is a broken pipe error here

simple-server/src/lib.rs

Lines 265 to 266 in 10103f5

 self.handle_connection(stream) 

 .expect("Error handling connection.");

from simple-server.

scurest commented on July 22, 2024

Oh. but there still isn't Content-Length for these errors:

simple-server/src/lib.rs

Lines 318 to 321 in 10103f5

 let resp = Response::builder() 

 .status(StatusCode::PAYLOAD_TOO_LARGE) 

 .body("<h1>413</h1><p>Request too large!<p>".as_bytes()) 

 .unwrap();

simple-server/src/lib.rs

Lines 341 to 343 in 10103f5

 let response = response_builder 

 .body("<h1>404</h1><p>Not found!<p>".as_bytes()) 

 .unwrap();

simple-server/src/lib.rs

Lines 378 to 380 in 10103f5

 let response = response_builder 

 .body("<h1>500</h1><p>Internal Server Error!<p>".as_bytes()) 

 .unwrap();

from simple-server.

Recommend Projects

Content-Length or Transfer-Encoding header (RFC 7230) about simple-server HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	self.handle_connection(stream)
	.expect("Error handling connection.");

	let resp = Response::builder()
	.status(StatusCode::PAYLOAD_TOO_LARGE)
	.body("<h1>413</h1><p>Request too large!<p>".as_bytes())
	.unwrap();

	let response = response_builder
	.body("<h1>404</h1><p>Not found!<p>".as_bytes())
	.unwrap();

	let response = response_builder
	.body("<h1>500</h1><p>Internal Server Error!<p>".as_bytes())
	.unwrap();