Giter VIP home page Giter VIP logo

Comments (14)

ashrafchowdury avatar ashrafchowdury commented on July 20, 2024 4

I would love to create the Notion-like table. you can assign me to this issue.

The CodeBlock, BlockQuote, HorizontalRule are not listed on the selectors that's why I thought those are not implemented yet.

from novel.

ashrafchowdury avatar ashrafchowdury commented on July 20, 2024 4

Hey @steven-tey πŸ‘‹

I created the Table format and implemented it in the editor, now I want feedback from you to before making the pr-request

Untitled.video.-.Made.with.Clipchamp.12.mp4

I have added:

  • Adding & deleting Column
  • Adding & deleting Row
  • Delete Table
  • A mune for the table

from novel.

mmailaender avatar mmailaender commented on July 20, 2024 3

After thinking about the first approach, I think I'm not so happy with it. I would prefer a more context-aware table like e.g. Figma Tables (The icons would be also simpler)

https://github.com/steven-tey/novel/assets/87228994/1d56ed93-f06f-413b-b63a-0d05816db5eb
(The table column delete in the video is happening with keyboard shortcut)

What do you think?

from novel.

steven-tey avatar steven-tey commented on July 20, 2024 2

@mmailaender that one looks incredible! Similar concept to Notion's implementation, which I really like :amazing-rainbow:

Would be incredible if we can implement that in Novel!

from novel.

steven-tey avatar steven-tey commented on July 20, 2024 1

@ashrafchowdury thanks for checking – definitely the first one! Let's use the simple table in Notion as reference :)

CleanShot 2023-06-22 at 10 51 35

from novel.

steven-tey avatar steven-tey commented on July 20, 2024 1

Quick update: Codeblock and blockquote have been added to slash menu in #35

from novel.

mmailaender avatar mmailaender commented on July 20, 2024 1

@steven-tey, @ashrafchowdury some suggestions for the icons:

image
image
image
image
image
image

If you like them, I provide the SVG code.

from novel.

ashrafchowdury avatar ashrafchowdury commented on July 20, 2024

I can add more useable formats to the editor, if you like the idea you can assign me to do this work.

from novel.

steven-tey avatar steven-tey commented on July 20, 2024

CodeBlock, BlockQuote and HorizontalRule are actually all supported!

Would love to add tables though – feel free to PR! You can use Tiptap tables as reference but would love to make it have a similar UX as Notion's tables (hover to add rows/tables)

CleanShot 2023-06-19 at 15 40 55

from novel.

ashrafchowdury avatar ashrafchowdury commented on July 20, 2024

Hey @steven-tey a quick question for you, I have to table design mockup for the editor, which one do you think is the best for users πŸ‘‡

This is clean and very much user-friendly.
image

This is a bit complex and requires a lot of functionalities.
image

from novel.

steven-tey avatar steven-tey commented on July 20, 2024

@ashrafchowdury looks incredible 🀯 only thing I can think of is the icons might not be clear enough πŸ˜…

Also, would it be possible to rearrange the columns?

Feel free to go ahead and add that PR and we can iterate on this!

P.S.: what does "a mune for the table" mean?

from novel.

ashrafchowdury avatar ashrafchowdury commented on July 20, 2024

@mmailaender we are using the lucide icon library for the project icons πŸ‘

from novel.

mmailaender avatar mmailaender commented on July 20, 2024

@mmailaender we are using the lucide icon library for the project icons πŸ‘

Except from the first icon they are self crafted, because we had the same situation that @steven-tey talks about, that e.g. the lucid icons don't have expressive icons for table.

from novel.

ashrafchowdury avatar ashrafchowdury commented on July 20, 2024

That looks really clean & awesome 😘

If we wanted to add that type of table then we have to spend a bit of time to build it from scratch.

from novel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.