Comments (8)
Version 9.0.0 published
from ngx-wig.
@DanielChuDC you could fork the repo and try to upgrade it using the ng update
command of the Angular CLI. After upgrade, make sure that you check all tests that pass. If you need any further assistance I would be happy to help 😃
from ngx-wig.
ok! thank you
from ngx-wig.
@DanielChuDC do you have any difficulties with Angular9?
from ngx-wig.
Hi,
I tried an update of the library to Angular 9 and provided an pr.
I needed to change the provider function of NgxWigModule
that provides the button Library to an inline function, because of a weird Migration issue that is related to angular 9:
> Undecorated classes with DI migration.
As of Angular 9, it is no longer supported to use Angular DI on a class that does not have an Angular decorator.
Read more about this here: https://v9.angular.io/guide/migration-undecorated-classes
This migration uses the Angular compiler internally and therefore projects that no longer build successfully after the update cannot run the migration. Please ensure there are no AOT compilation errors and rerun the migration. The following project failed: src/tsconfig.app.json
Error: error TS100: Error during template compile of 'AppModule'
Function calls are not supported in decorators but 'provideButtons' was called in 'NgxWigModule'
'NgxWigModule' calls 'provideButtons'.
Could not migrate all undecorated classes that use dependency
injection. Some project targets could not be analyzed due to
TypeScript program failures.
Tests are running fine, linting is having 2 issues (has been 4), I think the type can simply be changed to an interface, but I'm not 100% sure about the side effects:
ngx-wig/projects/ngx-wig/src/lib/config.ts[6, 13]: Use an interface instead of a type literal.
ngx-wig/projects/ngx-wig/src/lib/config.ts[14, 13]: Use an interface instead of a type literal.
from ngx-wig.
@stevermeister do you plan to update the npm package?
from ngx-wig.
yes, it's done now.
sorry, forgot to do it right after the merge.
from ngx-wig.
https://www.npmjs.com/package/ngx-wig/v/9.0.0
from ngx-wig.
Related Issues (20)
- Creating custom buttons for version 0.3.6 HOT 1
- [idea] CI to publish on npm HOT 2
- bubble editor
- Erroneous behavior trying to delete text from the editor HOT 4
- Custom Buttons for version 11.0.0.
- Event on blur HOT 1
- Use with validators HOT 1
- hide toolbar and change styles HOT 4
- configure it uses only tags I decide HOT 4
- Where is version 12 of the npm package? HOT 3
- Angular 13 support HOT 4
- Custom dropdown
- Remove legacy code HOT 1
- <br> tag left after textarea clear HOT 5
- Improve documentation about custom buttons. HOT 5
- Application error when custom button does not set `styleClass`
- Angular 14 support HOT 3
- Migrate to ESLint HOT 7
- npm package public version is still 13.2.6 HOT 1
- Angular 15 support HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-wig.