Giter VIP home page Giter VIP logo

Comments (3)

peduarte avatar peduarte commented on June 19, 2024

At the moment, numbers are not supported in most properties. This is because initially we didn't want to allow people to set a unitless number, and have it being converted to px value.

It seems that we've changed our minds about this, @colmtuite can you confirm, that now we do want to support unitless numbers? (with the exception of line-height)

@hadihallak maybe its worth doing this together when you implement the functionality?

from stitches.

peduarte avatar peduarte commented on June 19, 2024

Since we dont rely on css-types our implementation would probably be different

I've got it to work by changing the types to this:

export type GapProperty<TLength> =
  | Globals
  | TLength
  | "normal"
  | ((string | number) & {});

But will hold off until we can decide what to do

from stitches.

peduarte avatar peduarte commented on June 19, 2024

Done in #206

from stitches.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.